[rfc][icedtea-web] fix for RH947647, following the XDG basedir specification
Jiri Vanek
jvanek at redhat.com
Sat Jul 13 04:21:14 PDT 2013
On 07/12/2013 05:25 PM, Jiri Vanek wrote:
> On 07/12/2013 05:09 PM, Andrew Azores wrote:
>> On 07/12/2013 10:04 AM, Jiri Vanek wrote:
>>> Attempt two :)
>>>
>>> Well this test nearly cost me my sanity (not that there is to much left but...) but here it is
>>> again.
>>>
>>> As Omair have signed himself off this review (after saying that by concept it is ok) this patch is
>>> looking for volunteer.
>>>
>>> J.
>>
>> All looks good to me other than a couple style nitpicks, but nothing important. Just things like
>> missing spaces around + when concatenating strings, hardly worth changing :) I think this looks
>> pretty good as it is.
>>
>> I tried to apply the patches in my VM with latest ITW - the tests patch succeeded (as expected since
>> it's just file additions), but the other patch just about entirely failed :( I used hg patch -f
>> --no-commit for this. I tried to use the "patch" command but it complained about a malformed line,
>> so maybe I was just not using it correctly. Not sure what that's about, hopefully it's just a
>> problem on my end though and won't result in some merge conflict!
>>
>> Andrew A
>
> aargh, yah, I have not updated underlying repo.
>
> I will post new patch on top of head and with proper reformatting.
>
> Tahnx for check!
>
> J.
>
here we go!
(note changelog and neews added to patch)
Thanx, J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xdgSpecification4.patch
Type: text/x-patch
Size: 89818 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130713/0236c3b1/xdgSpecification4.patch
More information about the distro-pkg-dev
mailing list