More propagated about dialogue - part2 plugin
Andrew Azores
aazores at redhat.com
Mon Jul 15 11:28:23 PDT 2013
On 07/13/2013 10:05 AM, Jiri Vanek wrote:
> This patch made "version caption" of splash click-able, to show about
> dialogue.
> As side effect I changed window from JFrame to Dialogue. IMHO it
> should be Dialogu since begging, but I needed the modal functionality
> (otherwise dialogue is not accessible from other modal dialogue)
>
> 2013-07-13 Jiri Vanek <jvanek at redhat.com>
>
> About dialogue made accessible from plugin
> * netx/net/sourceforge/jnlp/about/AboutDialog.java: (frame)
> redeclared
> to be Dialogue instead of JFrame and allowed to be modal if
> necessary.
> Caption internationalized.
> *
> netx/net/sourceforge/jnlp/splashscreen/impls/DefaultSplashScreens2012Commons.java:
> Added listener for upper right caption to show AboutDialog
> *
> netx/net/sourceforge/jnlp/splashscreen/impls/defaultsplashscreen2012/BasePainter.java:
> (drawBase) if enough space, adding about "button"
> *
> netx/net/sourceforge/jnlp/splashscreen/parts/JEditorPaneBasedExceptionDialog.java:
> added about button
> *
> tests/netx/unit/net/sourceforge/jnlp/splashscreen/SplashScreenTest.java:
> minor modifications related to this change
Looks good except one little thing. In AboutDialog.java, line 80 -
JFrame.DISPOSE_ON_CLOSE should probably be changed to
JDialog.DISPOSE_ON_CLOSE, and then the JFrame import can be removed as well.
Andrew A
More information about the distro-pkg-dev
mailing list