[rfc][icedtea-web] TinyHttpdImpl refactor

[Jiri Vanek]

On 07/26/2013 05:34 PM, Andrew Azores wrote:
> Changelog:
> * tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java (TinyHttpdImpl): BufferedReader and DataOutputStream become member variables rather than local to run. More informative/mnemonic variable names
> (writeErrorToPipe): new private method.
> (writeToPipe): new private method.
> (run): refactored to use writeToPipe and writeErrorToPipe, and ensuring that streams are closed when no longer in use. More informative/mnemonic variable names
>
> The patch looks big (relative to the size of the file) but it's really almost entirely variable renaming and method extractions. :)
Does not, I'm dealyed due to packaging stuff ;( Sorry
Practicaly no objections to the code:
* The unittests for this are however a must - for new method, constructors and especially for run - to ensure they behave as they behaved before. Not that the backward compatibility is important in tests extensions, but because it worked pretty well.
I would rather this patch to be pushed to head only together with unittests, but if you swear, you can push in two pushes.

   Thanx for refactoring!
     J.