[rfc][icedtea-web] Stripping semicolon tags from jar urls

[Andrew Azores]

On 06/04/2013 04:50 AM, Jiri Vanek wrote:
> On 06/03/2013 07:06 PM, Andrew Azores wrote:
>> Changelog:
>>
>> * netx/net/sourceforge/jnlp/Parser.java: added call to 
>> UrlUtils.stripSemicolon()
>> * netx/net/sourceforge/jnlp/util/UrlUtils.java: added method 
>> stripSemicolon()
>>
>> * tests/netx/unit/net/sourceforge/jnlp/ParserBasic.java: added tests 
>> for Parser.getUrl()
>> * tests/netx/unit/net/sourceforge/jnlp/basic.jnlp: added case for 
>> ParserBasic
>> * tests/netx/unit/net/sourceforge/jnlp/util/UrlUtilsTest.java: added 
>> tests for UrlUtils.stripSemicolon()
>>
>> * 
>> tests/reproducers/simple/StripSemicolons/testcases/StripSemicolonsTest.java: 
>> added reproducer for UrlUtils.stripSemicolon()
>> * tests/reproducers/simple/StripSemicolons/srcs/StripSemicolons.java: 
>> class used in reproducer above
>> * 
>> tests/reproducers/simple/StripSemicolons/resources/stripsemicolons.jnlp: 
>> jnlp used to reference class above
>>
>>
>> Created unit tests and reproducer for this change, which has also 
>> been moved out into UrlUtils.
> Please split by logical units, not by files.
> In this case three patches - fix, tests, reproducr(s) (with testcase)
>
>
> J.
Hopefully this is more manageable :)

I definitely need some feedback on the reproducer, I'm not sure exactly 
what to be doing with it and at the moment it feels like it's just 
duplicating the unit tests.

Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 2285 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130604/b5ea22c5/fix.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducer.patch
Type: text/x-patch
Size: 8262 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130604/b5ea22c5/reproducer.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unit_tests.patch
Type: text/x-patch
Size: 14709 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130604/b5ea22c5/unit_tests.patch