[rfc][icedtea-web] Stripping semicolon tags from jar urls
Andrew Azores
aazores at redhat.com
Thu Jun 6 12:01:55 PDT 2013
> Unittests do also have strange indentation. Are you using some
> formatting tool? Both Netbens and Eclipse can do the job for you. In
> icedtea-web is .settiings directory with config files for ITW if you
> wont.
>
> After above is fixed, then I will push for you.
>
Ooh, I hadn't noticed that. Part of this was done in Eclipse and part
of it was in Vim, and I guess my vimrc setup is not quite right. I'll go
take a look at that.
> Also one more nit. As separate changeset, can you please
>
> extract the:
>
> p = URLDecoder.decode(p, "UTF-8");
> p = p.replaceAll("\\?.*", "");
> p = (".".concat((p.endsWith("/")) ?
> p.concat("index.html") : p)).replace('/', File.separatorChar);
> p = stripHttpPathParams(p);
>
> (and maybe few more lines)
Sure, I'll do that next.
New patches attached are same changeset as last time, just cleaned up
indentation and the rest of the things you mentioned.
Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 1794 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130606/ebeabf4e/fix.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducer.patch
Type: text/x-patch
Size: 10220 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130606/ebeabf4e/reproducer.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unit_test.patch
Type: text/x-patch
Size: 1603 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130606/ebeabf4e/unit_test.patch
More information about the distro-pkg-dev
mailing list