[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "function parameters" tests
Adam Domurad
adomurad at redhat.com
Wed Mar 6 12:35:15 PST 2013
On 03/06/2013 10:48 AM, Jana Fabrikova wrote:
> Hello,
>
> please see the attached patch of new reproducer for J->JS "calling JS
> function with various parameters from J".
>
> Several of the testcases in the patch have commented annotations
> KnownToFailInBrowser, (which i have implemented but is not included yet.)
Can you send a summary of the test failures to the mailing list please ?
The differing output would be useful. Thank you!
>
> thanks for any comments,
> Jana
>
> 2013-03-06 Jana Fabrikova <jfabriko at redhat.com>
>
> *
> /tests/reproducers/simple/JToJSFuncParam/testcases/JToJSFuncParamTest.java:
> adding 19 testcases based on the interactive Liveconnect JS->Java
> function parameters tests
>
> * /tests/reproducers/simple/JToJSFuncParam/srcs/JToJSFuncParam.java:
> the applet that calls JS function
>
> *
> /tests/reproducers/simple/JToJSFuncParam/resources/JToJS_FuncParam.js:
> auxiliary JavaScript code
>
> *
> /tests/reproducers/simple/JToJSFuncParam/resources/jtojs-funcparam.jnlp:
> jnlp file for displaying applet in the html page
>
> *
> /tests/reproducers/simple/JToJSFuncParam/resources/JToJSFuncParam.html:
> the html page where the applet calling JS function is embedded
This could definitely use a clearer name ... I had a long pause where I
didn't notice the different between 'JSToJ' and 'JToJS'. I was quite
confused, thinking you rewrote an already OK'd patch. Perhaps just
JavascriptFunctionParam is better?
> diff --git
> a/tests/reproducers/simple/JToJSFuncParam/resources/JToJSFuncParam.html b/tests/reproducers/simple/JToJSFuncParam/resources/JToJSFuncParam.html
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JToJSFuncParam/resources/JToJSFuncParam.html
> @@ -0,0 +1,27 @@
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> +<html lang="en-US">
> + <head>
> + <title>Java JavaScript LiveConnect - Function Parameters</title>
> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> +
> + <script language="JavaScript" src="JToJS_FuncParam.js"></script>
> +
> + </head>
> + <body>
> +
> + <h2> The JToJSFuncParam html page</h2>
> +
> + <applet code="JToJSFuncParam" width="1000" height="100"
> id="jtojsFuncParamApplet" MAYSCRIPT>
> + <param name="jnlp_href" value="jtojs-funcparam.jnlp">
> + </applet>
> +
> + <script type="text/javascript">
> +
> + var applet = document.getElementById('jtojsFuncParamApplet');
> +
> + doJJSFuncParamTests();
With code so short, you could just inline it here instead of having a
separate file.
> +
> + </script>
> +
> + </body>
> +</html>
> diff --git
> a/tests/reproducers/simple/JToJSFuncParam/resources/JToJS_FuncParam.js
> b/tests/reproducers/simple/JToJSFuncParam/resources/JToJS_FuncParam.js
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSFuncParam/resources/JToJS_FuncParam.js
> @@ -0,0 +1,19 @@
> +function JJSParameterTypeFunc(type_parameter,callid) {
IMO we don't need callid, we only need to have something like:
function test_types(obj, string_representation) {
applet.printOut( typeof(obj) + " type from Java object" );
var eval_obj = eval(string_representation);
applet.printOut( typeof(eval_obj) + " type from Javascript eval
object" );
}
And then all the strings can be passed from Java as such:
private void passToJavascript(Object obj, String repr){
window.call(jsFunctionName, new Object[]{ obj, repr });
}
private void passToJavascript(Object obj){
passToJavascript(obj, obj.toString());
}
> + var str = "Call with "+type_parameter.toString() + ":" +
> typeof(type_parameter) + " from " + callid;
> + applet.printOut(str);
> +}
> +
> +function doJJSFuncParamTests(){
> +
> + var urlArgs = document.URL.split("?");
> + var testParams = urlArgs[1].split(";");
> + var func = testParams[0];
> + var value = eval(decodeURIComponent(testParams[1]));
> +
> + eval('applet.'+func+'()');
Would applet[func]() work, not needing eval ? (not entirely sure)
> +
> + JJSParameterTypeFunc(value,"JS");
> +
> + applet.printOut("afterTests");
> +}
> +
> diff --git
> a/tests/reproducers/simple/JToJSFuncParam/resources/jtojs-funcparam.jnlp
> b/tests/reproducers/simple/JToJSFuncParam/resources/jtojs-funcparam.jnlp
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JToJSFuncParam/resources/jtojs-funcparam.jnlp
> @@ -0,0 +1,23 @@
> +
> +<?xml version="1.0" encoding="UTF-8"?>
> +<jnlp spec="1.0+" codebase="" href="jtojs-funcparam.jnlp">
> + <information>
> + <title>Java to JavaScript LiveConnect - FuncParam</title>
> + <vendor>IcedTea</vendor>
> + <homepage
> href="http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web"/>
> + <description>LiveConnect - tests for parameter conversion
> between Java and JavaScript.</description>
> + </information>
> + <resources>
> + <!-- Application Resources -->
> + <j2se version="1.6+"
> + href="http://java.sun.com/products/autodl/j2se"/>
> + <jar href="JToJSFuncParam.jar" main="true" />
> +
> + </resources>
> + <applet-desc
> + name="J to JS FuncParam"
> + main-class="JToJSFuncParam"
> + width="1000"
> + height="100">
> + </applet-desc>
> +</jnlp>
> diff --git
> a/tests/reproducers/simple/JToJSFuncParam/srcs/JToJSFuncParam.java
> b/tests/reproducers/simple/JToJSFuncParam/srcs/JToJSFuncParam.java
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSFuncParam/srcs/JToJSFuncParam.java
> @@ -0,0 +1,137 @@
> +import java.applet.Applet;
> +import netscape.javascript.JSObject;
> +
> +public class JToJSFuncParam extends Applet {
> +
> + public DummyObject dummyObject = new DummyObject("DummyObject1");
> + private JSObject window;
> +
> + private final String jsFunctionName = "JJSParameterTypeFunc";
> +
> + public void init() {
> + window = JSObject.getWindow(this);
> + String initStr = "JToJSFuncParam applet initialized.";
> + System.out.println(initStr);
> + }
> +
> + //methods for testing calling JavaScript function with different
> parameters
> + public void jjsCallintParam(){
> + int i = 1;
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> + public void jjsCalldoubleParam(){
> + double d = 1.1;
> + window.call(jsFunctionName, new Object[]{ d, "J" });
> + }
> +
> + public void jjsCallfloatParam(){
> + float f = 1.5f;
> + window.call(jsFunctionName, new Object[]{ f, "J" });
> + }
> +
> + public void jjsCalllongParam(){
> + long l = 10000;
> + window.call(jsFunctionName, new Object[]{ l, "J" });
> + }
> +
> + public void jjsCallshortParam(){
> + short s = 1;
> + window.call(jsFunctionName, new Object[]{ s, "J" });
> + }
> +
> + public void jjsCallbyteParam(){
> + byte b = 1;
> + window.call(jsFunctionName, new Object[]{ b, "J" });
> + }
> +
> + public void jjsCallcharParam(){
> + char c = 'a';
> + window.call(jsFunctionName, new Object[]{ c, "J" });
> + }
> +
> + public void jjsCallbooleanParam(){
> + boolean b = true;
> + window.call(jsFunctionName, new Object[]{ b, "J" });
> + }
> +
> + public void jjsCallIntegerParam(){
> + Integer i = new Integer(1);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallDoubleParam(){
> + Double i = new Double(1.5);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallFloatParam(){
> + Float i = new Float(1.5);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallLongParam(){
> + Long i = new Long(10000);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallShortParam(){
> + Short i = new Short((short)1);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallByteParam(){
> + Byte i = new Byte((byte)1);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallBooleanParam(){
> + Boolean i = new Boolean(true);
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallCharacterParam(){
> + Character i = new Character('a');
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallStringParam(){
> + String i = "teststring";
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallDummyObjectParam(){
> + DummyObject i = new DummyObject("dummy1");
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + public void jjsCallJSObjectParam(){
> + JSObject i = window;
> + window.call(jsFunctionName, new Object[]{ i, "J" });
> + }
> +
> + // auxiliary methods and class:
> + public void printOut(String s) {
> + System.out.println(s);
> + }
> +
> + public class DummyObject {
> + private String str;
> +
> + public DummyObject(String s) {
> + this.str = s;
> + }
> +
> + public void setStr(String s) {
> + this.str = s;
> + }
> +
> + public String toString() {
> + return str;
> + }
> + }
> +
> + public DummyObject getNewDummyObject(String s){
> + return new DummyObject(s);
> + }
> +
> +}
> diff --git
> a/tests/reproducers/simple/JToJSFuncParam/testcases/JToJSFuncParamTest.java
> b/tests/reproducers/simple/JToJSFuncParam/testcases/JToJSFuncParamTest.java
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JToJSFuncParam/testcases/JToJSFuncParamTest.java
> @@ -0,0 +1,225 @@
> +/* JToJSFuncParamTest.java
> +Copyright (C) 2012 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as
> published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +import net.sourceforge.jnlp.ProcessResult;
> +import net.sourceforge.jnlp.ServerAccess;
> +import net.sourceforge.jnlp.browsertesting.BrowserTest;
> +import net.sourceforge.jnlp.browsertesting.Browsers;
> +import net.sourceforge.jnlp.closinglisteners.CountingClosingListener;
> +import net.sourceforge.jnlp.annotations.NeedsDisplay;
> +import net.sourceforge.jnlp.annotations.TestInBrowsers;
> +//import net.sourceforge.jnlp.annotations.KnownToFailInBrowsers;
> +import org.junit.Assert;
> +
> +import org.junit.Test;
> +
> +public class JToJSFuncParamTest extends BrowserTest {
> +
> + private final String initStr = "JToJSFuncParam applet initialized.";
> + private final String afterStr = "afterTests";
> + private final String globStart = "Call with ";
> + private final String globEnd = " from JS";
> + private final String jEnd = " from J";
> +
> + private class CountingClosingListenerImpl extends
> CountingClosingListener {
> +
> + @Override
> + protected boolean isAlowedToFinish(String s) {
> + return (s.contains(initStr) && s.contains(afterStr));
> + }
> + }
> +
> + private void evaluateStdoutContents(ProcessResult pr) {
> + // Assert that the applet was initialized.
> + Assert.assertTrue("JToJSFuncParamTest stdout should contain "
> + initStr + " but it didnt.", pr.stdout.contains(initStr));
> +
> + // Assert that the results of two calls of js func are the same
> +
> + int gs = pr.stdout.indexOf(globStart);
> + int ge = pr.stdout.indexOf(globEnd);
> + int je = pr.stdout.indexOf(jEnd);
> + int jss = je + jEnd.length() + 1;
> +
> + String javaOutput = pr.stdout.substring(gs, je);
> + String jsOutput = pr.stdout.substring(jss, ge);
> +
> + Assert.assertTrue("JToJSFuncParam: the J and JS outputs are
> not equal!", javaOutput.equals(jsOutput));
> + }
> +
> + private void javaToJSFuncParamTest(String funcStr, String
> valueStr) throws Exception {
> +
> + String strURL = "/JToJSFuncParam.html?" + funcStr + ";" +
> valueStr;
> + ProcessResult pr = server.executeBrowser(strURL, new
> CountingClosingListenerImpl(), new CountingClosingListenerImpl());
> + evaluateStdoutContents(pr);
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_int_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallintParam", "1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_double_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCalldoubleParam", "1.1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_float_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallfloatParam", "1.5");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_long_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCalllongParam", "10000");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_short_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallshortParam", "1");
> + }
> +
>
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_byte_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallbyteParam", "1");
> + }
> +
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_char_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallcharParam", "97");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_boolean_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallbooleanParam", "true");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Integer_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallIntegerParam", "1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Double_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallDoubleParam", "1.5");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Float_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallFloatParam", "1.5");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Long_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallLongParam", "10000");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Short_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallShortParam", "1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Byte_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallByteParam", "1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Boolean_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallBooleanParam", "true");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_Character_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallCharacterParam", "97");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_String_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallStringParam", "\"teststring\"");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncParam_DummyObject_Test() throws
> Exception {
> + javaToJSFuncParamTest("jjsCallDummyObjectParam",
> "applet.getNewDummyObject(\"dummy1\")");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + //@KnownToFailInBrowsers(failsIn={Browsers.googleChrome,
> Browsers.chromiumBrowser})
> + public void AppletJToJSFuncParam_JSObject_Test() throws Exception {
> + javaToJSFuncParamTest("jjsCallJSObjectParam", "window");
I would say this more tests if we pass the window
> + }
> +
> +}
Looks good overall!
Happy hacking,
-Adam
More information about the distro-pkg-dev
mailing list