[icedtea-web][rfc] Extract native code caching from JNLPClassLoader into a small class
Jiri Vanek
jvanek at redhat.com
Tue Mar 12 07:26:04 PDT 2013
On 03/05/2013 10:20 PM, Adam Domurad wrote:
> This is an incremental part of the effort to reduce the responsibilities of JNLPClassLoader.
>
> 2013-03-05 Adam Domurad <adomurad at redhat.com>
>
> * netx/net/sourceforge/jnlp/cache/NativeLibraryStorage.java: New,
> stores and searches for native library files that are loaded from jars.
> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Move code
> that handled native jar caching to NativeLibraryStorage.
>
> Happy hacking,
> -Adam
Is there any more reason for this refactoring then much nicer, more readable, and testable jnlpclasslaoder?
Anyway I'm fan of this kind of refactoring. And I'm for this to be done.
- there must be unittests for this chnage
- i would like to see even reproducer for this
- it should go to 1.3 to after some time in head.
I have not check if there is something more then pure refactoring, but if there isn't and tsts will be added, then this will be approved.
J.
More information about the distro-pkg-dev
mailing list