[rfc][icedtea-web] KnownToFailInBrowsers annotation patch

[Jiri Vanek]

On 03/13/2013 05:13 PM, Jana Fabrikova wrote:
> Hello,
>
> I am sending for your consideration a patch that introduces the @KnownToFailInBrowsers annotation, which may be useful in some of the reproducers (namely passing arrays from JS->J does work in opera and firefox and does not work in google-chrome, chromium, midori and epiphany, and i think it is more problem of the browsers than of icedtea-web plugin).
>
> The annotation is detected in junit-runner/JunitLikeXmlOutputListener.java and junit-runner/LessVerboseTextListener.java and reflected in the console and xml output of run-netx-dist-tests.
>
> Cheers,
> Jana
>
> 2013-03-13 Jana Fabrikova <jfabriko at redhat.com>
>
> * /tests/test-extensions/net/sourceforge/jnlp/annotations/KnownToFailInBrowsers.java
> the implementation of new annotation, which has an array of
> browsers of type Browsers[] named failsIn
>
> * /tests/junit-runner/JunitLikeXmlOutputListener.java
> in method (testDone) the testcases that are known to fail in
> current browser are detected in addition to the tests that are
> k2f in all browsers
>
> * /tests/junit-runner/LessVerboseTextListener.java
> added method (getK2FinB) reading the annotion,
> in method (printK2F) the testcases that are known to fail in
> current browser are detected in addition to the tests that are
> k2f in all browsers

hmhm... I'm not sure If new type of annotation is needed. I would prefer extension of KnownTofail as it is.
Now it have no parameter. In your new implementation it will have optional  Browsers[] failsIn(). If it will be  null/empty, then it will behave as we are  used now. Otherwise it will be more sophisticated
What do you think?

For the implementation itself - uless I missed something, I'm terribly missing the browser recognition  handling in xml/plaintext generation and in xslt sheet.
Also some example usage of annotaion would be nice and as a top candy the screenshots of outputs can be attached.


J.