[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "function parameters" tests
Adam Domurad
adomurad at redhat.com
Thu Mar 21 09:30:21 PDT 2013
On 03/20/2013 06:31 AM, Jana Fabrikova wrote:
> Hi Adam,
>
> thank you for the review. I have changed the reproducer in several
> ways according to your comments:
>
> - the name JToJSFuncParam -> JavascriptFuncParam for better recognition
>
> - all the parameters (int 1, String "teststring",...) are now only in
> the applet code (applet passes to javascript the value and its text
> representation, so that javascript function is called once from the
> applet with the value and second from inside this function in
> javascript with the javascript-evaluated text representation)
>
> - the javascript code is inside the html page now
>
> - applet[func]() is used, it calls the functions ok
>
> On 03/06/2013 09:35 PM, Adam Domurad wrote:
>> On 03/06/2013 10:48 AM, Jana Fabrikova wrote:
>>> Hello,
>>>
>>> please see the attached patch of new reproducer for J->JS "calling JS
>>> function with various parameters from J".
>>>
>>> Several of the testcases in the patch have commented annotations
>>> KnownToFailInBrowser, (which i have implemented but is not included
>>> yet.)
>>
>
> The test that sends JSObject window as a parameter has normal output
> in Opera, Firefox, midori, epiphany:
>
> JToJSFuncParam applet initialized.
> Call with [object Window]:object from J
> Call with [object Window]:object from JS
> afterTests
>
>
> but the output from chromium and google-chrome is:
>
> JToJSFuncParam applet initialized.
> Call with [object Object]:object from J
> Call with [object Window]:object from JS
> afterTests
>
> maybe the annotation KnownToFail(failsIn={Browsers.chromium,
> Browsers.google-chrome} should be added to this particular testcase.
>
>
> The modified reproducer is in the attached patch,
> thanks,
> Jana
>
> [..snip..]
Thanks for the update! Keep up the good work.
> diff --git
> a/tests/reproducers/simple/JavascriptFuncParam/resources/JavascriptFuncParam.html
> b/tests/reproducers/simple/JavascriptFuncParam/resources/JavascriptFuncParam.html
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JavascriptFuncParam/resources/JavascriptFuncParam.html
> @@ -0,0 +1,40 @@
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> +<html lang="en-US">
> + <head>
> + <title>Java JavaScript LiveConnect - Function Parameters</title>
> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> + </head>
> + <body>
> +
> + <h2> The JToJSFuncParam html page</h2>
> +
> + <applet code="JavascriptFuncParam" width="1000" height="100"
> id="jtojsFuncParamApplet" MAYSCRIPT>
> + <param name="jnlp_href" value="javascript-funcparam.jnlp">
> + </applet>
> +
> + <script type="text/javascript">
> +
> + function JJSParameterTypeFunc(type_parameter, js_str_param) {
> + var str = "Call with "+type_parameter.toString() + ":" +
> typeof(type_parameter) + " from J";
> + applet.printOut(str);
> +
> + var value = eval(js_str_param);
> + JSSubFunc(value);
> + }
> +
> + function JSSubFunc(type_parameter) {
> + var str = "Call with "+type_parameter.toString() + ":" +
> typeof(type_parameter) + " from JS";
> + applet.printOut(str);
> + }
> +
> + var applet = document.getElementById('jtojsFuncParamApplet');
> + var urlArgs = document.URL.split("?");
> + var func = urlArgs[1];
> +
> + applet[func]();
> + applet.printOut("afterTests");
> +
> + </script>
> +
> + </body>
> +</html>
> diff --git
> a/tests/reproducers/simple/JavascriptFuncParam/resources/javascript-funcparam.jnlp
> b/tests/reproducers/simple/JavascriptFuncParam/resources/javascript-funcparam.jnlp
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JavascriptFuncParam/resources/javascript-funcparam.jnlp
> @@ -0,0 +1,23 @@
> +
> +<?xml version="1.0" encoding="UTF-8"?>
> +<jnlp spec="1.0+" codebase="" href="javascript-funcparam.jnlp">
> + <information>
> + <title>Java to JavaScript LiveConnect - FuncParam</title>
> + <vendor>IcedTea</vendor>
> + <homepage
> href="http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web"/>
> + <description>LiveConnect - tests for parameter conversion
> between Java and JavaScript.</description>
> + </information>
> + <resources>
> + <!-- Application Resources -->
> + <j2se version="1.6+"
> + href="http://java.sun.com/products/autodl/j2se"/>
> + <jar href="JavascriptFuncParam.jar" main="true" />
> +
> + </resources>
> + <applet-desc
> + name="J to JS FuncParam"
> + main-class="JavascriptFuncParam"
> + width="1000"
> + height="100">
> + </applet-desc>
> +</jnlp>
> diff --git
> a/tests/reproducers/simple/JavascriptFuncParam/srcs/JavascriptFuncParam.java
> b/tests/reproducers/simple/JavascriptFuncParam/srcs/JavascriptFuncParam.java
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JavascriptFuncParam/srcs/JavascriptFuncParam.java
> @@ -0,0 +1,146 @@
> +import java.applet.Applet;
> +import netscape.javascript.JSObject;
> +
> +public class JavascriptFuncParam extends Applet {
> +
> + public DummyObject dummyObject = new DummyObject("DummyObject1");
> + private JSObject window;
> +
> + private final String jsFunctionName = "JJSParameterTypeFunc";
> +
> + public void init() {
> + window = JSObject.getWindow(this);
> + String initStr = "JToJSFuncParam applet initialized.";
> + System.out.println(initStr);
> + }
> +
> + //methods for testing calling JavaScript function with different
> parameters
> + public void jjsCallintParam(){
> + int i = 1;
> + passToJavascript((Object) i);
[nit] Note, there is no need for this (Object) cast in this, and related
methods. See
http://docs.oracle.com/javase/1.5.0/docs/guide/language/autoboxing.html
> + }
> [..snipped..]
> +}
> diff --git
> a/tests/reproducers/simple/JavascriptFuncParam/testcases/JavascriptFuncParamTest.java
> b/tests/reproducers/simple/JavascriptFuncParam/testcases/JavascriptFuncParamTest.java
> new file mode 100644
> --- /dev/null
> +++
> b/tests/reproducers/simple/JavascriptFuncParam/testcases/JavascriptFuncParamTest.java
> @@ -0,0 +1,232 @@
> +/* JToJSFuncParamTest.java
> +Copyright (C) 2012 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as
> published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +import net.sourceforge.jnlp.ProcessResult;
> +import net.sourceforge.jnlp.ServerAccess;
> +import net.sourceforge.jnlp.browsertesting.BrowserTest;
> +import net.sourceforge.jnlp.browsertesting.Browsers;
> +import net.sourceforge.jnlp.closinglisteners.CountingClosingListener;
> +import net.sourceforge.jnlp.annotations.NeedsDisplay;
> +import net.sourceforge.jnlp.annotations.TestInBrowsers;
> +import org.junit.Assert;
> +
> +import org.junit.Test;
> +
> +public class JavascriptFuncParamTest extends BrowserTest {
> +
> + public final boolean doNotRunInOpera = true;
This isn't pleasing, but I have been advised this is a necessary evil
and that I should look the other way :-). I'm trusting Jiri's judgement
on this one.
> +
> [..snipped..]
Looks good, drop the (Object) cast if you feel like it, but OK to push.
-Adam
More information about the distro-pkg-dev
mailing list