[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "function return values" tests

Thu Mar 21 10:44:55 PDT 2013

On 03/06/2013 10:54 AM, Jana Fabrikova wrote:
> Hello,
>
> please see the attached patch of new reproducer for J->JS "getting the 
> right value by applet that calls JS functions with different return 
> types".
>
> thanks for any comments,
> Jana
>
> 2013-03-06 Jana Fabrikova <jfabriko at redhat.com>
>
> * 
> /tests/reproducers/simple/JToJSFuncReturn/testcases/JToJSFuncReturnTest.java:
> adding 5 testcases based on the interactive Liveconnect JS->Java
> function return type tests
>
> * /tests/reproducers/simple/JToJSFuncReturn/srcs/JToJSFuncReturn.java:
> the applet that calls JS functions
>
> * 
> /tests/reproducers/simple/JToJSFuncReturn/resources/JToJS_FuncReturn.js:
> auxiliary JavaScript code
>
> * 
> /tests/reproducers/simple/JToJSFuncReturn/resources/jtojs-funcreturn.jnlp:
> jnlp file for displaying applet in the html page
>
> * 
> /tests/reproducers/simple/JToJSFuncReturn/resources/JToJSFuncReturn.html:
> the html page where the applet calling JS functions is embedded


> diff --git 
> a/tests/reproducers/simple/JToJSFuncReturn/resources/JToJSFuncReturn.html 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/JToJSFuncReturn.html
> new file mode 100644
> --- /dev/null
> +++ 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/JToJSFuncReturn.html
> @@ -0,0 +1,27 @@
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> +<html lang="en-US">
> + <head>
> + <title>Java JavaScript LiveConnect - Function Return types</title>
> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> +
> + <script language="JavaScript" src="JToJS_FuncReturn.js"></script>
> +
> + </head>
> + <body>
> +
> + <h2> The JToJSFuncReturn html page</h2>
> +
> + <applet code="JToJSFuncReturn" width="1000" height="100" 
> id="jtojsFuncReturnApplet" MAYSCRIPT>
> + <param name="jnlp_href" value="jtojs-funcreturn.jnlp">
> + </applet>
> +
> + <script type="text/javascript">
> +
> + var value;
> +
> + doJToJSFuncReturnTests();
> +
> + </script>
> +
> + </body>
> +</html>
> diff --git 
> a/tests/reproducers/simple/JToJSFuncReturn/resources/JToJS_FuncReturn.js 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/JToJS_FuncReturn.js
> new file mode 100644
> --- /dev/null
> +++ 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/JToJS_FuncReturn.js
> @@ -0,0 +1,15 @@
> +function doJToJSFuncReturnTests(){
> + var applet = document.getElementById('jtojsFuncReturnApplet');
> +
> + var urlArgs = document.URL.split("?");
> + value = eval(decodeURIComponent(urlArgs[1]));
> +
> + applet.jCallJSFunction();
> +
> + applet.writeAfterTests();
> +}
> +
> +function jsReturningFunction(){
> + return value;
> +}
> +
> diff --git 
> a/tests/reproducers/simple/JToJSFuncReturn/resources/jtojs-funcreturn.jnlp 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/jtojs-funcreturn.jnlp
> new file mode 100644
> --- /dev/null
> +++ 
> b/tests/reproducers/simple/JToJSFuncReturn/resources/jtojs-funcreturn.jnlp
> @@ -0,0 +1,23 @@
> +
> +<?xml version="1.0" encoding="UTF-8"?>
> +<jnlp spec="1.0+" codebase="" href="jtojs-funcreturn.jnlp">
> + <information>
> + <title>Java to JavaScript LiveConnect - FuncReturn</title>
> + <vendor>IcedTea</vendor>
> + <homepage 
> href="http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web"/>
> + <description>LiveConnect - tests for returning different types of 
> values when calling JS function from Java.</description>
> + </information>
> + <resources>
> + <!-- Application Resources -->
> + <j2se version="1.6+"
> + href="http://java.sun.com/products/autodl/j2se"/>
> + <jar href="JToJSFuncReturn.jar" main="true" />
> +
> + </resources>
> + <applet-desc
> + name="J to JS FuncReturn"
> + main-class="JToJSFuncReturn"
> + width="1000"
> + height="100">
> + </applet-desc>
> +</jnlp>
> diff --git 
> a/tests/reproducers/simple/JToJSFuncReturn/srcs/JToJSFuncReturn.java 
> b/tests/reproducers/simple/JToJSFuncReturn/srcs/JToJSFuncReturn.java
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSFuncReturn/srcs/JToJSFuncReturn.java
> @@ -0,0 +1,46 @@
> +import java.applet.Applet;
> +import netscape.javascript.JSObject;
> +
> +public class JToJSFuncReturn extends Applet {
> +
> + private JSObject window;
> +
> + public void init() {
> + window = JSObject.getWindow(this);
> + String initStr = "JToJSFuncReturn applet initialized.";
> + System.out.println(initStr);
> + }
> +
> + // method for testing return types of JavaScript function
> + public void jCallJSFunction() {
> + String returnTypeTestFuncName = "jsReturningFunction";
> + Object ret = window.call(returnTypeTestFuncName, new Object[]{});
> + System.out.println(ret.toString());
> + }
> +
> + // auxiliary class and methods
> + public void writeAfterTests() {
> + System.out.print("afterTests");
> + }
> +
> + public class DummyObject {
> + private String str;
> +
> + public DummyObject(String s) {
> + this.str = s;
> + }
> +
> + public void setStr(String s) {
> + this.str = s;
> + }
> +
> + public String toString() {
> + return str;
> + }
> + }
> +
> + public DummyObject getNewDummyObject(String s){
> + return new DummyObject(s);
> + }
> +
> +}
> diff --git 
> a/tests/reproducers/simple/JToJSFuncReturn/testcases/JToJSFuncReturnTest.java 
> b/tests/reproducers/simple/JToJSFuncReturn/testcases/JToJSFuncReturnTest.java
> new file mode 100644
> --- /dev/null
> +++ 
> b/tests/reproducers/simple/JToJSFuncReturn/testcases/JToJSFuncReturnTest.java
> @@ -0,0 +1,116 @@
> +/* JToJSFuncReturnTest.java
> +Copyright (C) 2012 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as 
> published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 
> Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +import net.sourceforge.jnlp.ProcessResult;
> +import net.sourceforge.jnlp.ServerAccess;
> +import net.sourceforge.jnlp.browsertesting.BrowserTest;
> +import net.sourceforge.jnlp.browsertesting.Browsers;
> +import net.sourceforge.jnlp.closinglisteners.CountingClosingListener;
> +import net.sourceforge.jnlp.annotations.NeedsDisplay;
> +import net.sourceforge.jnlp.annotations.TestInBrowsers;
> +import org.junit.Assert;
> +
> +import org.junit.Test;
> +
> +public class JToJSFuncReturnTest extends BrowserTest {
> +
> + private final String initStr = "JToJSFuncReturn applet initialized.";
> + private final String afterStr = "afterTests";
> +
> + private class CountingClosingListenerImpl extends 
> CountingClosingListener {
> +
> + @Override
> + protected boolean isAlowedToFinish(String s) {
> + return (s.contains(initStr) && s.contains(afterStr));
> + }
> + }
> +
> + private void evaluateStdoutContents(String[] expectedStdoutsOR, 
> ProcessResult pr) {
> + // Assert that the applet was initialized.
> + Assert.assertTrue("JToJSFuncReturnTest stdout should contain " + 
> initStr + " but it didnt.", pr.stdout.contains(initStr));
> +
> + // Assert that the values set from JavaScript are ok
> + boolean atLeastOne = false;
> + for(String s : expectedStdoutsOR){
> + if(pr.stdout.contains(s)) atLeastOne = true;
> + }
> + Assert.assertTrue("JToJSFuncReturn: the output should include at 
> least one of expected Stdouts, but it didnt.", atLeastOne);
> + }
> +
> + private void javaToJSFuncReturnTest(String urlEnd, String[] 
> expectedValsOR) throws Exception {
> +
> + String strURL = "/JToJSFuncReturn.html?" + urlEnd;
> + ProcessResult pr = server.executeBrowser(strURL, new 
> CountingClosingListenerImpl(), new CountingClosingListenerImpl());
> + evaluateStdoutContents(expectedValsOR, pr);
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncReturn_number_Test() throws Exception {
> + javaToJSFuncReturnTest("123", new String[] {"123"});
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncReturn_boolean_Test() throws Exception {
> + javaToJSFuncReturnTest("true", new String[] {"true"});
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncReturn_String_Test() throws Exception {
> + javaToJSFuncReturnTest("\"��〒£$ǣ€��\"", new String[] {"��〒£$ǣ€��"});
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncReturn_Object_Test() throws Exception {
> + javaToJSFuncReturnTest("applet.getNewDummyObject(\"dummy1\")", new 
> String[] {"dummy1"});
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSFuncReturn_JSObject_Test() throws Exception {
> + javaToJSFuncReturnTest("window", new String[] {"[object Window]", 
> "[object DOMWindow]"});
> + }
> +
> +}

Looks good to me.
-Adam