[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "get" tests
Adam Domurad
adomurad at redhat.com
Thu Mar 21 10:58:33 PDT 2013
On 03/06/2013 10:35 AM, Jana Fabrikova wrote:
> Hello,
>
> please see the attached patch of new reproducer for J->JS "reading JS
> variables from J".
>
> Several of the testcases in the patch have commented annotations
> KnownToFailInBrowser, (which i have implemented but is not included yet.)
>
> thanks for any comments,
> Jana
>
> 2013-03-06 Jana Fabrikova <jfabriko at redhat.com>
>
> * /tests/reproducers/simple/JToJSGet/testcases/JToJSGetTest.java:
> adding 8 testcases based on the interactive Liveconnect JS->Java
> overloaded function resolution tests
>
> * /tests/reproducers/simple/JToJSGet/srcs/JToJSGet.java:
> the applet that reads variables from JS
>
> * /tests/reproducers/simple/JToJSGet/resources/JToJS_Get.js:
> auxiliary JavaScript code
>
> * /tests/reproducers/simple/JToJSGet/resources/jtojs-get.jnlp:
> jnlp file for displaying applet in the html page
>
> * /tests/reproducers/simple/JToJSGet/resources/JToJSGet.html:
> the html page where the applet reading JS variables is embedded
> diff --git a/tests/reproducers/simple/JToJSGet/resources/JToJSGet.html
> b/tests/reproducers/simple/JToJSGet/resources/JToJSGet.html
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSGet/resources/JToJSGet.html
> @@ -0,0 +1,27 @@
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> +<html lang="en-US">
> + <head>
> + <title>Java JavaScript LiveConnect - Get values from applet</title>
> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> +
> + <script language="JavaScript" src="JToJS_Get.js"></script>
> +
> + </head>
> + <body>
> +
> + <h2> The JToJSGet html page</h2>
> +
> + <applet code="JToJSGet" width="1000" height="100"
> id="jtojsGetApplet" MAYSCRIPT>
> + <param name="jnlp_href" value="jtojs-get.jnlp">
> + </applet>
> +
> + <script type="text/javascript">
> +
> + var jsvar;
> +
> + doJToJSGetTests();
> +
> + </script>
> +
> + </body>
> +</html>
> diff --git a/tests/reproducers/simple/JToJSGet/resources/JToJS_Get.js
> b/tests/reproducers/simple/JToJSGet/resources/JToJS_Get.js
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSGet/resources/JToJS_Get.js
> @@ -0,0 +1,14 @@
> +function doJToJSGetTests(){
> +
> + var applet = document.getElementById('jtojsGetApplet');
> +
> + var urlArgs = document.URL.split("?");
> + var testParams = urlArgs[1].split(";");
> + var func = testParams[0];
> + var value = decodeURIComponent(testParams[1]);
> +
> + eval('jsvar='+value);
> + eval('applet.'+func+'()');
> +
> + applet.writeAfterTests();
> +}
> diff --git
> a/tests/reproducers/simple/JToJSGet/resources/jtojs-get.jnlp
> b/tests/reproducers/simple/JToJSGet/resources/jtojs-get.jnlp
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSGet/resources/jtojs-get.jnlp
> @@ -0,0 +1,23 @@
> +
> +<?xml version="1.0" encoding="UTF-8"?>
> +<jnlp spec="1.0+" codebase="" href="jtojs-get.jnlp">
> + <information>
> + <title>Java to JavaScript LiveConnect - Get</title>
> + <vendor>IcedTea</vendor>
> + <homepage
> href="http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web"/>
> + <description>LiveConnect - tests for reading JavaScript
> values from Java.</description>
> + </information>
> + <resources>
> + <!-- Application Resources -->
> + <j2se version="1.6+"
> + href="http://java.sun.com/products/autodl/j2se"/>
> + <jar href="JToJSGet.jar" main="true" />
> +
> + </resources>
> + <applet-desc
> + name="J to JS Get"
> + main-class="JToJSGet"
> + width="1000"
> + height="100">
> + </applet-desc>
> +</jnlp>
> diff --git a/tests/reproducers/simple/JToJSGet/srcs/JToJSGet.java
> b/tests/reproducers/simple/JToJSGet/srcs/JToJSGet.java
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSGet/srcs/JToJSGet.java
> @@ -0,0 +1,93 @@
> +import java.applet.Applet;
> +import java.util.Arrays;
> +import netscape.javascript.JSObject;
> +
> +public class JToJSGet extends Applet {
> +
> + public DummyObject dummyObject = new DummyObject("DummyObject1");
> + public Object value;
> + private JSObject window;
> +
> + private final String jsvar = "jsvar";
> +
> + public void init() {
> + window = JSObject.getWindow(this);
> +
> + String initStr = "JToJSGet applet initialized.";
> + System.out.println(initStr);
> + }
> +
> + // methods for testing read from JavaScript variables
> + public void jjsReadInt() {
> + value = new Integer(window.getMember(jsvar).toString());
> + System.out.println(value);
> + }
> +
> + public void jjsReadDouble() {
> + value = new Double(window.getMember(jsvar).toString());
> + System.out.println(value);
> + }
> +
> + public void jjsReadBoolean() {
> + value = new Boolean(window.getMember(jsvar).toString());
> + System.out.println(value);
> + }
> +
> + public void jjsReadString() {
> + value = window.getMember(jsvar).toString();
> + System.out.println(value);
> + }
> +
> + public void jjsReadObject() {
> + value = window.getMember(jsvar).toString();
> + System.out.println(value);
> + }
> +
> + public void jjsRead1DArray() {
> + //value = ((JSObject) window.getMember(jsvar)).getSlot(1);
> + Object[] arrayvalue = (Object[]) window.getMember(jsvar);
> +
> + System.out.println(Arrays.toString(arrayvalue));
> + }
> +
> + public void jjsRead2DArray() {
> + //value = ((JSObject) ((JSObject)
> window.getMember(jsvar)).getSlot(1)).getSlot(2);
> + //value = ((JSObject) ((JSObject)
> window.getMember(jsvar)).getSlot(1));
I'd prefer not to leave around commented out code.
> + Object[][] arrayvalue = (Object[][])window.getMember(jsvar);
> +
> + System.out.println(Arrays.deepToString(arrayvalue));
> + }
> +
> + public void jjsReadJSObject() {
> + JSObject jsobjectvalue = (JSObject) window.getMember(jsvar);
> +
> + System.out.println(jsobjectvalue);
> + }
> +
> + //auxiliary class DummyObject
> + public class DummyObject {
> + private String str;
> +
> + public DummyObject(String s) {
> + this.str = s;
> + }
> +
> + public void setStr(String s) {
> + this.str = s;
> + }
> +
> + public String toString() {
> + return str;
> + }
> + }
> +
> + //auxiliary methods:
> + public DummyObject getNewDummyObject(String s){
> + return new DummyObject(s);
> + }
> +
> + public void writeAfterTests(){
> + System.out.println("afterTests");
> + }
> +
> +}
> diff --git
> a/tests/reproducers/simple/JToJSGet/testcases/JToJSGetTest.java
> b/tests/reproducers/simple/JToJSGet/testcases/JToJSGetTest.java
> new file mode 100644
> --- /dev/null
> +++ b/tests/reproducers/simple/JToJSGet/testcases/JToJSGetTest.java
> @@ -0,0 +1,139 @@
> +/* JToJSGetTest.java
> +Copyright (C) 2012 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as
> published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +import net.sourceforge.jnlp.ProcessResult;
> +import net.sourceforge.jnlp.ServerAccess;
> +import net.sourceforge.jnlp.browsertesting.BrowserTest;
> +import net.sourceforge.jnlp.browsertesting.Browsers;
> +import net.sourceforge.jnlp.closinglisteners.CountingClosingListener;
> +import net.sourceforge.jnlp.annotations.NeedsDisplay;
> +import net.sourceforge.jnlp.annotations.TestInBrowsers;
> +import net.sourceforge.jnlp.annotations.KnownToFailInBrowsers;
> +import org.junit.Assert;
> +
> +import org.junit.Test;
> +
> +public class JToJSGetTest extends BrowserTest {
> +
> + private final String initStr = "JToJSGet applet initialized.";
> + private final String afterStr = "afterTests";
> +
> + private class CountingClosingListenerImpl extends
> CountingClosingListener {
> +
> + @Override
> + protected boolean isAlowedToFinish(String s) {
> +
> + return (s.contains(initStr) && s.contains(afterStr));
> +
> + }
> + }
> +
> + private void evaluateStdoutContents(String expectedStdout,
> ProcessResult pr) {
> + // Assert that the applet was initialized.
> + Assert.assertTrue("JToJSGetTest stdout should contain " + initStr
> + + " but it didnt.", pr.stdout.contains(initStr));
> +
> + // Assert that the values get from JavaScript are ok
> + Assert.assertTrue("JToJsGet: the output should include:
> "+expectedStdout+", but it didnt.", pr.stdout.contains(expectedStdout));
> + }
> +
> + private void javaToJSGetTest(String funcStr, String paramStr,
> String expectedVal) throws Exception {
> + String strURL = "/JToJSGet.html?" + funcStr + ";" + paramStr;
> + ProcessResult pr = server.executeBrowser(strURL, new
> CountingClosingListenerImpl(), new CountingClosingListenerImpl());
> + evaluateStdoutContents(expectedVal, pr);
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + //@KnownToFailInBrowsers(failsIn={Browsers.midori,
> Browsers.googleChrome, Browsers.chromiumBrowser})
> + public void AppletJToJSGet_int_Test() throws Exception {
> + javaToJSGetTest("jjsReadInt", "1", "1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSGet_double_Test() throws Exception {
> + javaToJSGetTest("jjsReadDouble", "1.1", "1.1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSGet_boolean_Test() throws Exception {
> + javaToJSGetTest("jjsReadBoolean", "true", "true");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSGet_string_Test() throws Exception {
> + javaToJSGetTest("jjsReadString", "\"teststring\"", "teststring");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSGet_object_Test() throws Exception {
> + javaToJSGetTest("jjsReadObject",
> "applet.getNewDummyObject(\"dummy1\")", "dummy1");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + //@KnownToFailInBrowsers(failsIn={Browsers.midori,
> Browsers.epiphany, Browsers.googleChrome, Browsers.chromiumBrowser})
> + public void AppletJToJSGet_1DArray_Test() throws Exception {
> + javaToJSGetTest("jjsRead1DArray", "[1,2,3]", "[1, 2, 3]");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + //@KnownToFailInBrowsers(failsIn={Browsers.midori,
> Browsers.epiphany, Browsers.googleChrome, Browsers.chromiumBrowser})
> + public void AppletJToJSGet_2DArray_Test() throws Exception {
> + javaToJSGetTest("jjsRead2DArray", "[[1,2],[3,4]]","[[1, 2],
> [3, 4]]");
> + }
> +
> + @Test
> + @TestInBrowsers(testIn = { Browsers.all })
> + @NeedsDisplay
> + public void AppletJToJSGet_JSObject_Test() throws Exception {
> + javaToJSGetTest("jjsReadJSObject", "window","[object Window]");
> + }
> +
> +}
Looks OK to me. As I stated, I'd prefer this renamed JavascriptGet.
-Adam
More information about the distro-pkg-dev
mailing list