[rfc][icedtea-web] read properties values from C part - library edition :)

[Adam Domurad]

>>> +static string temporary_file(const string& contents) {
>>> +    string path = tmpnam(NULL); /* POSIX function, fine for test
>>> suite */
>>> +    ofstream myfile;
>>> +    myfile.open (path.c_str());
>>> +    myfile << contents;
>>> +    myfile.close();
>>> +    return path;
>>> +}
>>
>> [nit] You actually replaced my suggestion with a version that uses a
>> deprecated class :-)
>>
>
> Yah, sorry, your was not working :((

Probably because I wrote it in the body of the email (and not because of 
fstream), but it's no big deal.

[..snip..]

>> OK. I'll admit I just mostly trusted you for the tests. Thanks for
>> testing it so thoroughly!
>> I like to use artificial {} blocks to separate the different test
>> cases within a single function,
>> that way you can reuse the same variable names.
>> See for example PluginParametersTest. Anyway, I'll understand if you
>> don't want to go back and
>> change it.
>>
>> I may have missed it -- does this add any functional to ITW yet ?
>
> Not yet. It will be completely separated changeset.
> Using this code :)
>>
>> Anyway, looks overall OK. I'd like to see another round, my main
>> concerns are 'default_file_name'
>> being a global ambiguous constant, and 'trim' being available as a
>> general (tested! :-) utility
>> function.
>
> Yup - done - with most of the nits except deprecated streams.
>>
>> Very happy that you gave C++ a chance :-)
> /me thnax for mentoring!

Looks good, just one thing -- all the other string utilities are static 
functions in the class IcedTeaPluginUtilities. I'd prefer strongly if 
this was consistent (even if a bit more wordy). When a person looks for 
such a utility function, they may miss it otherwise.

Thanks.
-Adam

>
>