[rfc][icedtea-web] Strip parameters from document-base

Jiri Vanek jvanek at redhat.com
Thu Mar 28 04:53:35 PDT 2013


On 03/27/2013 09:20 PM, Adam Domurad wrote:
> It appears having parameters in the URL for the stored document-base can cause problems with some
> applets, namely the Oracle LMS applet.
>
> A small bit of refactoring is needed to move the URL stripping code:
>
> Refactoring ChangeLog:
> 2013-03-26  Adam Domurad  <adomurad at redhat.com>
>
>      * netx/net/sourceforge/jnlp/security/appletextendedsecurity/UnsignedAppletTrustConfirmation.java
>      (normalizeUrlAndStripParams): Moved.
>      * netx/net/sourceforge/jnlp/util/UrlUtils.java
>      (normalizeUrlAndStripParams): New, moved from
>      UnsignedAppletTrustConfirmation.
>      *
> tests/netx/unit/net/sourceforge/jnlp/security/appletextendedsecurity/UnsignedAppletTrustConfirmationTest.java
>
>      (testNormalizeUrlAndStripParams): Moved.
>      * tests/netx/unit/net/sourceforge/jnlp/util/UrlUtilsTest.java:
>      New, has (testNormalizeUrlAndStripParams) from
>      UnsignedAppletTrustConfirmationTest.
>
>
> And the fix itself:
> 2013-03-26  Adam Domurad  <adomurad at redhat.com>
>
>      * netx/net/sourceforge/jnlp/NetxPanel.java
>      (NetxPanel): Ensure documentURL has stripped parameters
>
> Happy hacking,
> -Adam

The refactoring is ok. But to use completely stripped codeabse in base codebase sounds to me as 
quite big change. As far as i looked, I was not able to judge all the  impact and would rather stay 
with more conservative change or with very deep testing of this change on your side.

J.




More information about the distro-pkg-dev mailing list