[rfc][icedtea-web] Refactor pipe-message mock code from PluginAppletViewerTest into PluginPipeMockUtils

Pavel Tisnovsky ptisnovs at redhat.com
Thu May 2 07:08:01 PDT 2013


Hi Adam,

this patch looks correct, ok for HEAD. I'm just a bit worried about the code
which parses string transfered from/to C-part of ITW. AFAIK someone should think
about improvements of this part (but obviously it's outside the range of this patch).

Cheers,
Pavel

----- Adam Domurad <adomurad at redhat.com> wrote:
> Hi all. This patch takes out some bits that are strongly not 
> test-specific. This will make it easier to use the pipe mock in other tests.
> I would still like to add more utility functions here, but this is a 
> good starting base. Some functions call through the pipe even though it 
> is not the main focus of the function, and something really convenient 
> to respond to certain message types would be ideal in that case (I have 
> a little bit written, but I'd like this base reviewed first).
> 
> Changes:
> 2013-XX-XX  Adam Domurad  <adomurad at redhat.com>
> 
>      Introduce PluginPipeMock utility methods.
>      * tests/test-extensions/sun/applet/PluginPipeMockUtil.java: New,
>      enapsulates PluginPipeMock initialization, cleanup. As well, contains
>      utility methods.
>      * tests/netx/unit/sun/applet/PluginAppletViewerTest.java: Use
>      newly introduced utility methods.
> 
> Happy hacking,
> -Adam




More information about the distro-pkg-dev mailing list