Reviewer needed: three new JTreg tests for IcedTea6 HEAD (text layout subsystem)

[Pavel Tisnovsky]

----- Jiri Vanek <jvanek at redhat.com> wrote:
> On 05/15/2013 01:50 PM, Pavel Tisnovsky wrote:
> > Hi everyone,
> >
> > I'd like to add three new JTreg tests into IcedTea6 HEAD (it is not backport).
> > These tests check the rest of text layout subsystem.
> >
> > FYI: I'm also going to ask for inclusion of these three test into
> > OpenJDK8 HEAD and then backporting them into OpenJDK7 too.
> >
> > Mercurial diff created against IcedTea6 HEAD is stored in an attachment.
> >
> > ChangeLog entry:
> > 2013-05-15  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >
> > 	* Makefile.am:
> > 	(ICEDTEA_PATCHES): Added new patch.
> > 	* patches/textLayoutBoundsChecks.patch:
> > 	Patch containing three new JTreg tests TextLayoutAscentDescent.java,
> > 	TextLayoutBoundIsNotEmpty and TextLayoutGetPixelBounds that
> > 	check the behavior of text layout subsystem.
> >
> > Can anybody please review this change?
> >
> > Thank you in advance,
> > Pavel Tisnovsky
> >
> 
> Looks ok to me, hgowever two nits
>   - it would be nice to have bugid in changelog (test themselves?) to bug it reproduces

unfortunately there's not bug ID for those tests. FYI: these tests check the behavior
of IT6 after latest security patches are updated, incl. changes made by Roman Kennke
and there is not bug# in Oracle DB for this change.

>   - I think there is  misisng makefile entry.

doh, you are right, please look at fixed hg.diff

Pavel

> 
> Please post fixed version before push itself.
> 
> Thank you for this!
>     J.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hg.diff
Type: text/x-patch
Size: 6906 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130515/67b5a30e/hg.diff