Reviewer needed: three new JTreg tests for IcedTea6 HEAD (text layout subsystem)

Andrew Hughes gnu.andrew at redhat.com
Wed May 15 07:05:46 PDT 2013



----- Original Message -----
> Hi everyone,
> 
> I'd like to add three new JTreg tests into IcedTea6 HEAD (it is not
> backport).
> These tests check the rest of text layout subsystem.
> 
> FYI: I'm also going to ask for inclusion of these three test into
> OpenJDK8 HEAD and then backporting them into OpenJDK7 too.
> 
> Mercurial diff created against IcedTea6 HEAD is stored in an attachment.
> 
> ChangeLog entry:
> 2013-05-15  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
> 	* Makefile.am:
> 	(ICEDTEA_PATCHES): Added new patch.
> 	* patches/textLayoutBoundsChecks.patch:
> 	Patch containing three new JTreg tests TextLayoutAscentDescent.java,
> 	TextLayoutBoundIsNotEmpty and TextLayoutGetPixelBounds that
> 	check the behavior of text layout subsystem.
> 
> Can anybody please review this change?
> 
> Thank you in advance,
> Pavel Tisnovsky
> 

I think the patch name should have something in it to represent that these
are jtreg tests; just a "jtreg-" prefix would do.  I think this is the case
for some existing patches.

Otherwise, fine.  Thanks for this.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list