[icedtea-web][rfc] Extract native code caching from JNLPClassLoader into a small class

[Adam Domurad]

On 03/12/2013 10:26 AM, Jiri Vanek wrote:
> On 03/05/2013 10:20 PM, Adam Domurad wrote:
>> This is an incremental part of the effort to reduce the 
>> responsibilities of JNLPClassLoader.
>>
>> 2013-03-05 Adam Domurad <adomurad at redhat.com>
>>
>> * netx/net/sourceforge/jnlp/cache/NativeLibraryStorage.java: New,
>> stores and searches for native library files that are loaded from jars.
>> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Move code
>> that handled native jar caching to NativeLibraryStorage.
>>
>> Happy hacking,
>> -Adam
>
> Is there any more reason for this refactoring then much nicer, more 
> readable, and testable jnlpclasslaoder?
> Anyway I'm fan of this kind of refactoring. And I'm for this to be done.
>
> - there must be unittests for this chnage
> - i would like to see even reproducer for this
> - it should go to 1.3 to after some time in head.

Probably a little late now, but 1.4 sure, unless you think 1.3 is still 
a good idea.

>
> I have not check if there is something more then pure refactoring, but 
> if there isn't and tsts will be added, then this will be approved.

It is a refactoring only.

>
> J.

I have created some unit tests, hopefully it is enough to push with ?
There is some bundled refactoring of the test extensions, hopefully it 
is ok.

2013-05-23  Adam Domurad  <adomurad at redhat.com>

     * 
tests/netx/unit/net/sourceforge/jnlp/runtime/JNLPClassLoaderTest.java:
     Moved MockedOneJarJNLPFile to separate DummyJNLPFileWithJar. Moved
     utilities to ExecUtils & FileDescriptorUtils.
     * 
tests/netx/unit/net/sourceforge/jnlp/cache/NativeLibraryStorageTest.java:
     New, tests lookup of native libraries from folders and jars.
     * 
tests/test-extensions/net/sourceforge/jnlp/mock/DummyJNLPFileWithJar.java:
     Moved from JNLPClassLoaderTest.MockedOneJarJNLPFile.
     * tests/test-extensions/net/sourceforge/jnlp/util/ExecUtils.java:
     New, provides utility for exec'ing cleanly and logging.
     * 
tests/test-extensions/net/sourceforge/jnlp/util/FileDescriptorUtils.java
     (getOpenFileDescriptorCount): Moved here, counts open files.
     (assertNoFileLeak): Moved here, asserts a runnable does not leak file
     descriptors.

Happy hacking,
-Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-native-library-storage.patch
Type: text/x-patch
Size: 26631 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130523/5be7e012/test-native-library-storage.patch