[rfc][icedtea-web] Removing applications tab in jawas-about

[Andrew Azores]

On 05/27/2013 06:56 AM, Jiri Vanek wrote:
> On 05/24/2013 09:45 PM, Andrew Azores wrote:
>> On 05/22/2013 10:22 AM, Jiri Vanek wrote:
>>> On 05/22/2013 03:25 PM, Andrew Azores wrote:
>>>> Removed applications.html and references to it in "jawas -about"
>>>>
>>>> Changelog:
>>>>
>>>> extra/net/sourceforge/javaws/about/Main.java: Removed applications tab
>>>> extra/net/sourceforge/javaws/about/resources/applications.html: 
>>>> Removed unneeded file
>>>
>>>
>>> Hi! To be honest - I'm for complete removal of this "about". Or at 
>>> least of much more havy
>>> refactoring
>>>
>>> Also to be honest(2) this is so deeply needed that it deserves an 
>>> line in
>>> http://icedtea.classpath.org/wiki/IcedTea-Web#IcedTea-Web_1.5 table.
>>>
>>> It should work at least somehow in headless mode, and should be 
>>> generated from already existing
>>> resources (eg authors, news...)
>>>
>>> So in short - get rid of "extras" jar (and it logic in makefile) and 
>>> write specialised about
>>> dialogue inisde netx itself:) Feel free to be inspired by existing 
>>> one, but avoid duplicated
>>> resources.
>>>
>>> if you want to bother with it (+1!) then please assign yourself on
>>> http://icedtea.classpath.org/wiki/IcedTea-Web#IcedTea-Web_1.5, and 
>>> go on!
>>>
>>>
>>>
>>> Best regards from CZ!
>>>   J.
>>
>> Hi Jiri,
>>
>> I'll take a look into creating that dialogue, it should be a good 
>> opportunity for me to keep
>> learning more about the code base before delving into more difficult 
>> tasks.
>>
>
> here you are 
> http://icedtea.classpath.org/wiki/IcedTea-Web#IcedTea-Web_1.5 :))
>
> Please try to move in as small steps as possible or split the patch to 
> as many logically-complete parts as possible, otherwise they will be 
> very difficult to review.
> This change should be simple code, but there will be probably huger 
> amount of it.
> You can start with moving the window into embedded one out of extreas.
> Also it would be nice to have as much of it generated from NEWS, 
> AUTHORS, maybe Changelog, COPYING? Reuse the rest?
> just nits... I do not wont to put boundaries to your imagination which 
> must be much more fresh then my is :)
>
> Best regards
>   J.
>
>
>
Changelog:

Makefile.am: removed logic for extras.jar

netx/net/sourceforge/jnlp/runtime/Boot.java: Added -headless -about mode

netx/net/sourceforge/jnlp/resources/Messages.properties: Added messages 
used in -headless -about

netx/net/sourceforge/jnlp/about/About.java: Changed name from Main, 
moved out of extras, added logic to generate content from AUTHORS, 
COPYING, NEWS, ChangeLog

netx/net/sourceforge/jnlp/resources/about.jnlp: References changed About 
class

netx/net/sourceforge/jnlp/about/Constants.java: String constants pulled 
out of About.java

netx/net/sourceforge/jnlp/about/HTMLPanel.java: Moved out of extras.jar

netx/net/sourceforge/jnlp/resources/about.html: Relocated

netx/net/sourceforge/jnlp/resources/applications.html: Relocated

netx/net/sourceforge/jnlp/resources/jamIcon.jpg: Relocated

netx/net/sourceforge/jnlp/resources/notes.html: Relocated and commented 
out authors lines since there is a new Authors tab

Lots of changed files but most of them have small changes made to them 
eg relocation, hopefully this is not too hard to review overall. I'm 
also not sure what else should be done for -about -headless, I'd 
definitely like some feedback on what else to put in there.

Thanks,

Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: about.html.patch
Type: text/x-patch
Size: 239 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/about.html.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: about.jnlp.patch
Type: text/x-patch
Size: 546 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/about.jnlp.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: About.java.patch
Type: text/x-patch
Size: 4696 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/About.java.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: applications.html.patch
Type: text/x-patch
Size: 267 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/applications.html.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Boot.java.patch
Type: text/x-patch
Size: 1288 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/Boot.java.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Constants.java.patch
Type: text/x-patch
Size: 1165 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/Constants.java.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HTMLPanel.java.patch
Type: text/x-patch
Size: 579 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/HTMLPanel.java.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jamIcon.jpg.patch
Type: text/x-patch
Size: 243 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/jamIcon.jpg.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.am.patch
Type: text/x-patch
Size: 6164 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/Makefile.am.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Messages.properties.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/Messages.properties.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notes.html.patch
Type: text/x-patch
Size: 639 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130531/b4147c34/notes.html.patch