[rfc][icedtea-web] Reproducers deprecation warning cleanup

Jiri Vanek jvanek at redhat.com
Thu Nov 7 01:59:26 PST 2013

On 11/06/2013 09:49 PM, Andrew Azores wrote:
> The attached archive contains 39 (!) patches. Each one corresponds to a testcase file, or the
> ServerAccess or ProcessWrapper classes. In the case of the testcases and ProcessWrapper, the changes
> include minor formatting fixes, or fixing the filename in license headers a few times, as well as
> changing references to ServerAccess.ProcessResult to use the standalone ProcessResult class, and
> changing the package name for JUnit. In ServerAccess, it's just formatting and the removal of the
> deprecated inner ProcessResult class.
> Changelog:
> * tests/test-extensions/net/sourceforge/jnlp/ServerAccess.java: removed ProcessResult inner class
> * tests/test-extensions/net/sourceforge/jnlp/ProcessWrapper.java: use standalone ProcessResult
> rather than ServerAccess.ProcessResult
> * tests/test-extensions-tests/net/sourceforge/jnlp/ResourcesTest.java: use standalone ProcessResult
> rather than ServerAccess.ProcessResult, use new JUnit package, fix formatting
> * tests/reproducers/simple/simpletest2/testcases/SimpleTest2Test.java: same
> etc. for 35 more files...

Its fir work behind this clean up, thanx for it.

Few hints:

- I would dicourage you from CreateClassLoaderLunch1 -> CreateClassLoaderLunch renaming
  - it will make mess in statistics
- I would dicourage you from listing all affected files. I would just wrote so,mething like  get rid 
of ServerAccess.ProcessResult and   junit.framework.Assert (in favour of ProcessResult and 
   - however for other chnages (like strict typing, or rmeoval of inner class) those files should be 
- few times there are no op changes like "   " to  " " empty lines. I would probbaly rather not 
include those changes.

After those, please feel free to push.


More information about the distro-pkg-dev mailing list