[rfc][icedtea-web] allow access to jars' attributes from jnlpfile class

Jiri Vanek jvanek at redhat.com
Thu Nov 7 07:19:40 PST 2013


As jnlp file is argument passed to various security dialogues, it should have access to attributes.
This is continuation of http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2013-October/025070.html

I do not have good feelings from patch,  but jnlpfile x jnlp classloader encapsulation ... or 
"encapsulation" is what it is :(

As the result this patch is implementing 
http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/manifest.html#app_name

Also I have found 
http://icedtea.classpath.org/hg/icedtea-web/file/dcd51951d507/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java#l831 
So I would like to ask if this condition is correct. IMO not. There should be :
  if (launchDesc != null) {
	mainClass = launchDesc.getMainClass();
  }

Or am I missing something?

Also there is a lot of "if (mainClass == null){work}if (mainClass == null){work} " as speed up there 
should be some "if (mainClass == null ) return"  hmm?


J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addedAccessToManifestsAttributesFromJnlpFile.patch
Type: text/x-patch
Size: 24604 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131107/00500d69/addedAccessToManifestsAttributesFromJnlpFile.patch 


More information about the distro-pkg-dev mailing list