[rfc][icedtea-web] unittests' stdout/err silencer

Andrew Azores aazores at redhat.com
Tue Nov 12 07:34:59 PST 2013


On 11/11/2013 11:16 AM, Jiri Vanek wrote:
> Once "[rfc][icedtea-web] allow access to jars' attributes from 
> jnlpfile class" is pushed, few tests will start to disturb stdout/err.
>
> This simple patch will silence them. If/after:) "Re: 
> [rfc][icedtea-web] allow access to jars' attributes from jnlpfile 
> class"  will go to 1.4 then something similar (stdout/err redirection) 
> will go here to.
>
> The disturbing message is recommended by specification, I do not wont 
> to add specific switches for individual logging streams.
>
> J.

This seems okay, but I don't really understand what the comments are 
trying to tell me.

//it is crucial for junit to grip it

I don't know what this means :)

Also, license header on the NoStdOutErrTest says 2011-2012 on it.

Okay to push when these minor nits are fixed.

Thanks,

-- 
Andrew A



More information about the distro-pkg-dev mailing list