[rfc][icedtea-web] removed most of checks to no output

Andrew Azores aazores at redhat.com
Mon Nov 25 06:41:03 PST 2013


On 11/25/2013 09:16 AM, Jiri Vanek wrote:
> This patch is stabilizing reproducers by removing checks for output 
> lengths from all "normal" reproducers.
> In remote reproducers, where the "no output" is sometimes only point 
> to pass/fail ( :((( ), the different approach was taken.
>
> J.

Why the change from "const char*" to "char*" in IcedTeaNPPlugin.cc? 
Intentional or just something that slipped past? This results in a build 
error (failure.txt attachment) for me.

Otherwise the patch looks good. Just running the tests myself to verify it.

Thanks,

-- 
Andrew A

-------------- next part --------------
/home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaNPPlugin.cc: In function ‘char* NP_GetMIMEDescription()’:
/home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaNPPlugin.cc:1955:24: error: new declaration ‘char* NP_GetMIMEDescription()’
 NP_GetMIMEDescription ()
                        ^
In file included from /home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaNPPlugin.h:44:0,
                 from /home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaJavaRequestProcessor.h:47,
                 from /home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaScriptablePluginObject.h:45,
                 from /home/aazores/icedtea/icedtea-web/build/../plugin/icedteanp/IcedTeaNPPlugin.cc:56:
/usr/include/xulrunner-25.0/npfunctions.h:283:52: error: ambiguates old declaration ‘const char* NP_GetMIMEDescription()’
 NP_EXPORT(const char*) NP_GetMIMEDescription(void);


More information about the distro-pkg-dev mailing list