[rfc][icedtea-web] removed most of checks to no output
Andrew Azores
aazores at redhat.com
Mon Nov 25 07:36:02 PST 2013
Okay to push :)
Thanks.
----- Original Message -----
From: "Jiri Vanek" <jvanek at redhat.com>
To: "Andrew Azores" <aazores at redhat.com>
Cc: "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
Sent: Monday, November 25, 2013 9:52:18 AM
Subject: Re: [rfc][icedtea-web] removed most of checks to no output
On 11/25/2013 03:41 PM, Andrew Azores wrote:
> On 11/25/2013 09:16 AM, Jiri Vanek wrote:
>> This patch is stabilizing reproducers by removing checks for output lengths from all "normal" reproducers.
>> In remote reproducers, where the "no output" is sometimes only point to pass/fail ( :((( ), the different approach was taken.
>>
>> J.
>
> Why the change from "const char*" to "char*" in IcedTeaNPPlugin.cc? Intentional or just something that slipped past? This results in a build error (failure.txt attachment) for me.
Yes, it slipped past. It was old system build. And I used same build dir as src dir. Thanx for noticing.
>
> Otherwise the patch looks good. Just running the tests myself to verify it.
>
> Thanks,
>
More information about the distro-pkg-dev
mailing list