[rfc][icedtea-web] filelog for plugin

[Andrew Azores]

On 11/28/2013 08:38 AM, Jiri Vanek wrote:
> Generally this patch is enabling the possibility lo log to file from 
> plugin (if enabled) + clean up + synchronisation with java (moreover 
> all the same still arround)
> - side effects:
>    - user can see/set KEY_USER_LOG_DIR in itw settings. This was 
> already implemented in netx, just needed to be enabled 
> (DebuggingPanel.java, Messages.properties)
>    - the name of the log made readable (and synchronised across java x 
> c)(FileLog.java)
>    - PluginMessageHandlerWorker.java commented out the "woken" 
> message. It had no sense
>    - c part -  except main parts of this patch, also various missing 
> end of lines or %s in outputs (which were to much visible in file log!)
>        (IcedTeaNPPlugin.cc,)defined filename and  stream, made aware 
> of console logging (to be synced with java part)
>            two notes - stream is flushed but not closed after shutdown 
> (it can write even after, and I have not find place to where to close it)
>                      -  from each browser run 1-aLotOf plugin file 
> logs are created (mostly twe) reason is, that  some calls are like 
> "lunhcig new executable" - namely GetMIMEDescription and one more
>       IcedTeaParseProperties.cc - added functions to read 
> deployment.user.logdirdeployment.user.logdir (or  return default) and 
> "deployment.console.startup.mode
>   - IcedTeaPluginUtils.cc - new util methods to generate logfile name, 
> to init the lofgile and to print logging status
>   - IcedTeaPluginUtils.h - the headers are generated only once during 
> debug/error processing, and reused both for file log and streams log 
> (and also error/debug)
>
> The patch is much more simple then it looks like :o)
>
> As guessable, part of huge rework I posted recently. For any brave 
> soul and larger overview the complete patch is attached again (so th 
> efile logging is doubled)
>
> J.

I only reviewed the smaller patch (fileLoggingForPlugin), but it looks 
good to me.

Thanks,

-- 
Andrew A