[rfc][icedtea-web] make console aware of plugin messages

Jiri Vanek jvanek at redhat.com
Fri Nov 29 08:35:48 PST 2013


So another part of "big console rewrote", now making the plugin console aware of C messages.
Design is simple. New write pipe from plugin to java is created, and console then read messgaes from it, and merge to outputs.
Right now it is not ideal, but with new console (which wil come later) it made much more sense.
There is small refactoring which made header as object (pluginheader and javaheader classes) , and change to string when needed.
The new pipe had best performance from tested files, current pipes and sockets
two nits:
  you will see my synchronisatoion by 1s sleep is not ideal in C part. any better idea?
Also you can see hat imput is char*, and also char* is written to pipe, however queue is using string -  I was not able to make it work via with char* :( so there is nasty char* -> string -> char* retyping ;( but I do not wont to malock and free the memory manually :P

Again a patch is much more simple (600lines is headers refactoring!)

Thanx for review!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: consolePluginAware.diff
Type: text/x-patch
Size: 52061 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131129/6bd7fd28/consolePluginAware-0001.diff 

More information about the distro-pkg-dev mailing list