[icedtea-web] RFC: Unit tests for BrowserAwareProxySelector

[Omair Majid]

On 09/30/2013 12:43 PM, Andrew Azores wrote:
> On 09/27/2013 07:32 PM, Omair Majid wrote:
>> On 09/24/2013 02:46 PM, Omair Majid wrote:
>>> Hi,
>>>
>>> The attached patch adds unit tests for BrowserAwareProxySelector and
>>> makes minor changes to make testing it easier.
>>>
>>> It also removes duplicate logic of selecting a host and port depending
>>> on the protocol into JNLPProxySelector.getFromArguments. The semantics
>>> of 'sameProxy' are different between BrowserAwareProxySelector and
>>> JNLPProxy selector; the socks proxy is included in firefox [1].
>>>
>> Ping. Can anyone review this?
> 
> Different filename in the license header of
> BrowserAwareProxySelectorTest.java.
> 

> Anyway, like I said I don't insist on this refactoring, because the
> tests are still readable and make clear sense. The class is just a lot
> longer in LoC than it probably has to be :) your call on bothering with
> refactor or not. Just fix the filename in that license header before
> push at least though.

Thanks for the suggestions. Does the attached patch look okay?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser-aware-proxy-tests-02.patch
Type: text/x-patch
Size: 17760 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20131001/cb200409/browser-aware-proxy-tests-02.patch