[rfc][icedtea-web] DeploymentPropertiesAreExposed reproducer fix

[Andrew Azores]

On 09/26/2013 02:58 PM, Andrew Azores wrote:
> On 09/26/2013 03:20 AM, Jiri Vanek wrote:
>> On 09/25/2013 09:40 PM, Andrew Azores wrote:
>>> On 09/20/2013 03:19 AM, Jiri Vanek wrote:
>>>> ok, discussion have been taken :))
>>>>
>>>> now whats about original patch?
>>>>
>>>>
>>>>
>>>> Changelog:
>>>> * netx/net/sourceforge/jnlp/config/Defaults.java: 
>>>> (USER_CONFIG_HOME) made public
>>>> *
>>>> tests/reproducers/signed/DeploymentPropertiesAreExposed/testcases/DeploymentPropertiesAreExposedTest.java: 
>>>>
>>>> fixed log dir location
>>>>
>>>>
>>>> Another casualty of the XDG spec change ;)
>>>>
>>>> Thanks,
>>>>
>>>
>>> I don't know enough to comment further on what the three of you have 
>>> already discussed in this
>>> thread. I am convinced that there should be a better method for 
>>> getting access to those Defaults
>>> values than simply making them public, but I can't say I know what 
>>> to actually do instead in order
>>> to keep everything secure and not leak information. In any case this 
>>> reproducer being broken in the
>>> meantime, until that better system is determined, is not an urgent 
>>> issue IMO. Perhaps it should just
>>> be put off for now.
>>>
>>> Thanks,
>>>
>> I'm for making it public. The field should be well protected in netx.
>>
>>
>> J.
>
> Actually, since the test is about checking that the 
> DeploymentConfiguration data is available through 
> System.getProperty()... is there any reason I can't just "abuse" the 
> DeploymentConfiguration singleton from JNLPRuntime again? Should work 
> just fine, I think still captures the "spirit" of this test, and also 
> means we can leave that constant in Defaults as default visibility.
>
> Thanks,
>
Ping?

Thanks,

-- 
Andrew A