[icedtea-web] RFC: Move some proxy logic to BrowserAwareProxySelector

[Jiri Vanek]

On 10/07/2013 05:25 PM, Omair Majid wrote:
> On 10/07/2013 11:06 AM, Jiri Vanek wrote:
>> On 10/05/2013 01:45 AM, Omair Majid wrote:
>>> Hi,
>>>
>>> The attached patch tries to clean up some code by moving some logic
>>> around asking the browser for proxy into BrowserAwareProxySelector,
>>> which seems more appropriate to keep this logic compared to the
>>> catch-all class PluginAppletViewr.
>>>
>> What is torubeling me a bit is change or parameter from uri to string.
>> Why so?
>
> Because the request to the browser currently takes a string:

Although I would rather keep uri in parameter (no metter that proxy request is string, the parammeter IS uri) you can proceed in your (or with uri-ed) version.

>
> String requestURI = null;
> requestURI = convertUriSchemeForProxyQuery(uri);
> PluginCallRequest request =
>    requestFactory.getPluginCallRequest("proxyinfo",
>                   "plugin PluginProxyInfo reference " + reference + " " +
>                    requestURI, reference)
>
>
> The convertUriSchemeForProxy is now part of the ProxySelector, so this
> method accepts a string directly.
>
>> I think more uri-validity checks ...even better.
>
> Any suggestions? I just refactored code (no functional changes unless I
> screwed up).
>
> Cheers,
> Omair
>