Small refactoring in searching for attributes

Omair Majid omajid at redhat.com
Fri Oct 18 08:00:28 PDT 2013


* Jiri Vanek <jvanek at redhat.com> [2013-10-18 09:14]:
> Please note, this have to go also to 1.4, and that tests are already included n itw.

Patch itself looks okay to me. You have introduced two new public
methods, though:

> +    public String checkForAttributeInJars(List<JARDesc> jars, Attributes.Name name) {

> +    public String getManifestAttribute(URL location, Attributes.Name  attribute) {

Could you add unit tests for these new methods? Just like the previous
unit tests give us some guarantee that users of the old methods are
still covered, it would be nice to have some guarantee that users are
also covered if these new methods were refactored too.

Thanks,
Omair


More information about the distro-pkg-dev mailing list