[rfc][icedtea-web] refactored logging
Omair Majid
omajid at redhat.com
Tue Oct 22 07:50:39 PDT 2013
* Jiri Vanek <jvanek at redhat.com> [2013-10-22 10:43]:
> On 10/22/2013 04:06 PM, Omair Majid wrote:
> >And when I look at the tests, the only thing they care about is
> >resetting it to the default value.
>
> Yes, thats what I'm worying a bit. That you do not do do backup,
> restore, but just reset. However it should be ok here..
I am not sure I follow. The test wants to start off with a clean state,
right? So resetting to the default makes sense. Doing a backup would
make more sense if some tests rely on the modified value of LogConfig.
But that's the opposite of each unit test being self contained and only
testing a 'unit' of the system. I think any test that relies on some
other test to change the logging config (and not explicitly set it) is
broken.
So, can you explain under what conditions doing a backup/reset would be
better?
Cheers,
Omair
More information about the distro-pkg-dev
mailing list