[icedtea-web] (PR1513) Signed JAR with external main-class

[Omair Majid]

* Andrew Azores <aazores at redhat.com> [2013-10-29 16:01]:
> I've attached another patch which does the job and is easier to
> reason about. I think I prefer the dialog presented by the last
> patch, as there's only one dialog that appears in that one - this
> patch causes there to be two, and they might be a little confusing
> to see in succession. See the applet at [1] with either patch
> applied to see the difference. As well, marking the main-class as
> external as in the older patch might be useful in the future for
> other purposes. But at least for fixing the particular bug report
> which caused this investigation, I think this new patch is
> sufficient and importantly, easier to verify as not introducing any
> issues with loading unverified classes. If we have any problems like
> that, they are pre-existing and can be addressed separately from
> this changeset IMHO.

I like this patch a little more. It's easier to reason about and keeps
things localized. I am not terribly happy about two dialogs, but since
this is such a corner case, it should be okay.

> Also the reproducers added last time require intervention to approve
> and run with this new patch as the other dialog box still appears
> even if you have security set to never prompt. Which, really, might
> be something else to look into changing.

You might want to hold off on the reproducers, then. They are supposed
to be completely automated.

> -                                R("LCClient"), R("LCantDetermineMainClass"),
> -                                R("LCantDetermineMainClassInfo"));

If these two strings are not used anywhere, please remove them from the
messages file too.

Thanks,
Omair