[rfc][icedtea-web] Temporary files location chooser cleanup

[Jiri Vanek]

On 08/01/2013 05:14 PM, Jacob Wisor wrote:
> Hello,
> 
> * Made temporary files location JFileChooser open at the currently specified location
> * Made temporary files location JFileChooser display a helpful title
> * Removed misleading "All Files" file filter from JFileChooser
> * Added new message to resources for JFileChooser's choose button
> * Fixed a few inconsistent messages in resource files

Thank you, such an "make it looks better" contributions are more then welcomed!
> 
> @Jiri
> Please add a cs translation for the new "TIFPFileChooserChooseButton" message.

It will be "Vybrat", but I prefer to sync the translations in longer time periods in bulk.
> 
> Regards,
> Jacob
> 
> 
> Temporary files FileChooser cleanup.patch
> 
> 
> diff -r f1eaa1ee7891 netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> +++ b/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> @@ -109,10 +109,12 @@
>           bLocation.addActionListener(new ActionListener() {
>               @Override
>               public void actionPerformed(ActionEvent e) {
> -                JFileChooser fileChooser = new JFileChooser();
> +                JFileChooser fileChooser = new JFileChooser(location.getText());

Tehre maybe should be some check if the location give sense. But The jefilechooser is probably handling this.

>                   fileChooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
>                   fileChooser.setFileHidingEnabled(false);
> -                if (fileChooser.showOpenDialog(null) == JFileChooser.APPROVE_OPTION) {
> +                fileChooser.setAcceptAllFileFilterUsed(false);

Why this? Isn't selection restricted enough by JFileChooser.DIRECTORIES_ONLY ?

> +                fileChooser.setDialogTitle(Translator.R("TIFPLocationLabel"));
> +                if (fileChooser.showDialog(null, Translator.R("TIFPFileChooserChooseButton")) == JFileChooser.APPROVE_OPTION) {
>                       // Check if we have permission to write to that location.
>                       String result = fileChooser.getSelectedFile().getAbsolutePath();
>                       File dirLocation = new File(result);
> @@ -242,4 +244,4 @@
> 
>           config.setProperty(properties[2], spCacheSize.getValue().toString());
>       }
> -}
> +}
> \ No newline at end of file
> diff -r f1eaa1ee7891 netx/net/sourceforge/jnlp/resources/Messages.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages.properties
> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties
> @@ -291,7 +292,7 @@
>   CVUser=User
>   CVSystem=System
> 
> -#KeyStores: see KeyStores.java
> +# KeyStores: see KeyStores.java
>   KS=KeyStore
>   KSCerts=Trusted Certificates
>   KSJsseCerts=Trusted JSSE Certificates
> @@ -461,6 +462,7 @@
>   TIFPCacheSize=Set the amount of disk space for storing temporary files
>   TIFPDeleteFiles=Delete files
>   TIFPViewFiles=View files...
> +TIFPFileChooserChooseButton=Choose


It will be "Vybrat"
> 
>   # Control Panel - Cache Viewer
>   CVCPDialogTitle=Cache Viewer
> diff -r f1eaa1ee7891 netx/net/sourceforge/jnlp/resources/Messages_cs.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages_cs.properties
> +++ b/netx/net/sourceforge/jnlp/resources/Messages_cs.properties
> @@ -278,6 +278,7 @@
>   CVUser=U\u017eivatel
>   CVSystem=Syst\u00e9m
> 
> +# KeyStores: see KeyStores.java
>   KS=\u00dalo\u017ei\u0161t\u011b kl\u00ed\u010d\u016f
>   KSCerts=D\u016fv\u011bryhodn\u00e9 certifik\u00e1ty
>   KSJsseCerts=D\u016fv\u011bryhodn\u00e9 certifik\u00e1ty JSSE
> diff -r f1eaa1ee7891 netx/net/sourceforge/jnlp/resources/Messages_de.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages_de.properties
> +++ b/netx/net/sourceforge/jnlp/resources/Messages_de.properties
> @@ -193,9 +194,10 @@
>   BOAbout=Zeigt eine Beispielanwendung.
>   BONosecurity=Deaktiviert die sichere Laufzeitumgebung.
>   BONoupdate=Deaktiviert die Pr\u00fcfung nach Aktualisierungen.
> -BOHeadless=Deaktiviert Herunterladefenster, andere Benutzeroberfl\u00e4chen.
> +BOHeadless=Deaktiviert Herunterladefenster und andere\n                        Benutzeroberfl\u00e4chen.


hmhmh, this.. "andere\n                        Benutzeroberfl" loong space is caused by reason? Was it intentional split by "\n" or unwilling action?
I would rather prefer single lines, as it is already an custom in itw properties.

>   BOStrict=Aktiviert die strikte Pr\u00fcfung des JNLP-Dateiformats.
>   BOViewer=Zeigt die Ansicht der vertrauensw\u00fcrdigen Zertifikate.
> +BOXml=Verwendet einen strikten XML-Parser f\u00fcr die JNLP-Datei.
>   BXnofork=Keine weitere JVM erstellen.
>   BXclearcache=Den JNLP-Anwendungszwischenspeicher s\u00e4ubern.
>   BXignoreheaders=Die Pr\u00fcfung der Metadaten von Jar-Dateien auslassen.
> @@ -285,6 +287,7 @@
>   CVUser=Benutzer
>   CVSystem=System
> 
> +# KeyStores: see KeyStores.java
>   KS=Schl\u00fcsselspeicher
>   KSCerts=Vertrauensw\u00fcrdige Zertifikate
>   KSJsseCerts=Vertrauensw\u00fcrdige JSSE Zertifikate
> @@ -454,6 +457,7 @@
>   TIFPCacheSize=Menge des Plattenplatzes zur Speicherung tempor\u00e4rer Dateien
>   TIFPDeleteFiles=Dateien l\u00f6schen
>   TIFPViewFiles=Dateien anzeigen...
> +TIFPFileChooserChooseButton=Ausw\u00e4hlen
> 
>   # Control Panel - Cache Viewer
>   CVCPDialogTitle=Zwischenspeicheranzeige
> diff -r f1eaa1ee7891 netx/net/sourceforge/jnlp/resources/Messages_pl.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages_pl.properties
> +++ b/netx/net/sourceforge/jnlp/resources/Messages_pl.properties
> @@ -196,6 +197,7 @@
>   BOHeadless=Wy\u0142\u0105cza okno pobierania i inne interfejsy graficzne
>   BOStrict=W\u0142\u0105cza \u015bcis\u0142e sprawdzanie format pliku JNLP
>   BOViewer=Pokazuje podgl\u0105d zaufanych certyfikat\u00f3w
> +BOXml=Stosuje \u015bcis\u0142y analizator sk\u0142adniowy XML do analizy\n                        pliku JNLP
>   BXnofork=Nie tw\u00f3rz nast\u0119pnej JVM
>   BXclearcache=Wyczy\u015b\u0107 pami\u0119\u0107 podr\u0119czn\u0105 aplikacji JNLP
>   BXignoreheaders=Pomijaj weryfikacj\u0119 nag\u0142\u00f3wk\u00f3w plik\u00f3w jar
> @@ -285,6 +287,7 @@
>   CVUser=U\u017cytkownik
>   CVSystem=System
> 
> +# KeyStores: see KeyStores.java
>   KS=Baza kluczy
>   KSCerts=Zaufane certyfikaty
>   KSJsseCerts=Zaufane certyfikaty JSSE
> @@ -454,6 +457,7 @@
>   TIFPCacheSize=Nastaw wielko\u015b\u0107 miejsca na dysku do sk\u0142adowania plik\u00f3w tymczasowych
>   TIFPDeleteFiles=Usu\u0144 pliki
>   TIFPViewFiles=Przegl\u0105daj pliki...
> +TIFPFileChooserChooseButton=Wybierz
> 
>   # Control Panel - Cache Viewer
>   CVCPDialogTitle=Podgl\u0105d pami\u0119ci podr\u0119cznej

Thank you very much to stitch with it and sorry for nits!

J.