[rfc][icedtea-web] RH976833 ClassLoader deadlock

Omair Majid omajid at redhat.com
Fri Sep 6 08:41:10 PDT 2013


On 09/06/2013 06:08 AM, Jiri Vanek wrote:
> General nit - it would be necessary  add javadocs why affected fields
> have been made synchronised and why affected methods are no longer
> synchronised.

Something to watch out for: the more you use low-level synchronization
features, the more the chances of unnecessary locking and/or deadlocks.

If you can use higher level abstractions for concurrency/locking (eg: a
built in data structure or some form of work queue) it will also explain
(in code) what's going on _and_ most likely be more correct in terms of
locking.

Cheers,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681



More information about the distro-pkg-dev mailing list