[rfc][icedtea-web] Archive URL wrongly resolved - PR1204

Andrew Azores aazores at redhat.com
Thu Sep 26 06:31:18 PDT 2013

On 09/25/13 17:32, Omair Majid wrote:
> On 09/25/2013 05:09 PM, Andrew Azores wrote:
>> On 09/25/2013 03:55 PM, Omair Majid wrote:
>>> One request for future patches: please keep the changelog in the format
>>> that you will add to the ChangeLog file.
>> Hmm? Did the formatting come out weird?
> Yes, the lines look a little strange:
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2013-September/024823.html
> It's not a big deal, though.

Oh yea I see what you mean. That is strange, I definitely didn't mean 
for them to look that way.

>> +            testQueryForBrowserProxyUsesHttpFallback(uri, result);
>> +            String hierarchicalPath = result.getAuthority() + result.getPath();
>> +            testQueryForBrowserProxyContainsNoDoubleSlashes(hierarchicalPath);
>> +            testQueryForBrowserProxyDoesNotChangeQuery(uri, result);
> I meant these three as separate @Test methods. What have you have done
> is okay too, but it might be better to rename the methods to be assert*
> (like assertUrlFallsBackToHttp) to reflect what they are doing.

Ah okay. Making each @Test would work too but then the testcases would 
be a little more redundant looking. Good idea with the naming though.

>> +    // Test that only HTTP is used as fallback scheme if a protocol other than HTTP(S) or FTP is specified
>> +    public void testQueryForBrowserProxyUsesHttpFallback(URI expected, URI result) {
>> +    // Test that absolute resource paths do not result in double-slashes within the URI
>> +    public void testQueryForBrowserProxyContainsNoDoubleSlashes(String uri) {
>> +    // Test that the query string of the URI is not changed
>> +    public void testQueryForBrowserProxyDoesNotChangeQuery(URI expected, URI result) {
> Otherwise okay to me. I am still not comfortable enough with the
> reproducers to think that I have reviewed it, but otherwise feel free to
> push with the suggestions above.
> Cheers,
> Omair


Andrew A

More information about the distro-pkg-dev mailing list