[icedtea-web] RFC: Unit tests for BrowserAwareProxySelector

Omair Majid omajid at redhat.com
Fri Sep 27 16:32:39 PDT 2013


On 09/24/2013 02:46 PM, Omair Majid wrote:
> Hi,
> 
> The attached patch adds unit tests for BrowserAwareProxySelector and
> makes minor changes to make testing it easier.
> 
> It also removes duplicate logic of selecting a host and port depending
> on the protocol into JNLPProxySelector.getFromArguments. The semantics
> of 'sameProxy' are different between BrowserAwareProxySelector and
> JNLPProxy selector; the socks proxy is included in firefox [1].
> 

Ping. Can anyone review this?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the distro-pkg-dev mailing list