[rfc][icedtea-web] Permissions manifest attribute fix

Andrew Azores aazores at redhat.com
Tue Apr 1 15:28:50 UTC 2014


On 04/01/2014 11:02 AM, Jiri Vanek wrote:
> +    public void testgetRequestedPermissionLevel() throws MalformedURLException, Exception {

Capitalize the 'g' in 'get' please. Otherwise ok.

Attached patch should be applied on top of yours. The differences from 
the previous versions are that it makes ManifestAttributesChecker 1) 
account for the DEFAULT value 2) attempt to setRunInSandbox, and if it 
fails, show an exception indicating to try the Sandbox button manually. 
As usual, testcase can be [0]. Without the patch applied, the applet is 
blocked due to being signed but requesting sandbox permissions. With the 
patch applied, choosing to run it normally gives a failure, suggesting 
you try running it in Sandbox manually. Running it in Sandbox manually 
allows the applet to run as expected.

[0] 
http://docs.oracle.com/javase/tutorial/deployment/deploymentInDepth/examples/dist/depltoolkit_Java2Demo/DeployUsingJNLP.html

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: permissions-attr-check-fix-2.patch
Type: text/x-patch
Size: 8530 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140401/66ccf1f1/permissions-attr-check-fix-2.patch>


More information about the distro-pkg-dev mailing list