[icedtea-web] RFC: Clean up some code in ClasspathMatcher

Jiri Vanek jvanek at redhat.com
Wed Apr 2 14:59:52 UTC 2014


On 04/02/2014 04:51 PM, Omair Majid wrote:
> Hi,
>
> The attached patch renames a method in ClasspathMatcher to better
> reflect what the method does.
>
> Okay for HEAD?
>
> Thanks,
> Omair
>


If you really insists - then converToRegEx would be even more suitable, or not? The method is not 
quoting or just chnaging wildcards * to .*, It is doing both :)

Also why to remove the comment? Andrew asked me for it explicitly when I wrote those peaces. So I 
think more people may be confused in future. Maybe at least add link to pattern documentation?


J.





More information about the distro-pkg-dev mailing list