[rfc][icedtea-web] add AM_MAINTAINER_MODE
Jiri Vanek
jvanek at redhat.com
Mon Apr 7 10:12:12 UTC 2014
On 04/02/2014 06:55 PM, Omair Majid wrote:
> * Jiri Vanek <jvanek at redhat.com> [2014-04-02 12:48]:
>> On 04/02/2014 06:36 PM, Omair Majid wrote:
>>> * Matthias Klose <doko at ubuntu.com> [2014-04-02 12:32]:
>>>> Note that AM_MAINTAINER_MODE(disable) has the same behaviour as not
>>>> including the macro. It only gives the package builder the option
>>>> to turn it on or off.
>>>
>>> You mean AM_MAINTAINER_MODE([enable]), right?
>
> This is not a +1 (or a -1) to add this, FWIW.
>
>> Plain AM_MAINTAINER_MODE should be enough, And the default should bne disabled, or not?
>
> No. That's probably not what you want.
>
> AM_MAINTAINER_MODE([disable]) is the same as AM_MAINTAINER_MODE.
>
> With AM_MAINTAINER_MODE, if I edit configure.ac and rerun configure, a
> new configure script from configure.ac will not be generated.
>
> For more comments on this, see:
> https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/
> http://lists.x.org/archives/xorg-devel/2012-September/033760.html
>
You have still not uncover why this change is needed:)
Otherwise
Adding
AM_MAINTAINER_MODE
into configure.ac is ok for head.
This allows to pass both ‘--enable-maintainer-mode’ or ‘--disable-maintainer-mode’ to configure.
J.
More information about the distro-pkg-dev
mailing list