[rfc][icedtea-web] disconnecting httpurlconnections

Andrew Azores aazores at redhat.com
Wed Apr 30 15:26:41 UTC 2014


On 04/30/2014 08:47 AM, Jiri Vanek wrote:
> Hi!
>
> I started to tweek https, and I found,that no urlconnection (which is 
> in 99% httpurlconnection) do not disconnect after calling 
> url.openConnection().
> Although after calling openConnection, the connection do not need to 
> be in "open" state, nor individual operations needs to call manually 
> connect() it should be disconnected (as the operations mostly call 
> connect).
> Although it do not mind for http (to much), it meters for https 
> connection a lot.
>
> I have tested this patch a lot, including manual testaces (and so 
> eluminate and webex) and it seems to be not breaking anything.
>
>
> Thoughts? 1.5?
>
>
> J.

Seems to work for me too and I don't see any problems with the patch, so 
okay. I'm for backporting as well.

As a side note, I had to use 'patch -p1' rather than 'hg import' due to 
trailing CR... are you using a different editor or diff tool now or 
something?

Thanks,

-- 
Andrew A



More information about the distro-pkg-dev mailing list