[rfc][icedtea-web] offline support

[Jacob Wisor]

On 08/04/2014 05:34 PM, Jiri Vanek wrote:
>
> The leading code was CacheUtil.cleanCache, which is making some complicated
> decisions whether to delete file. I have not found  case when keep all should be
> usefull. (?????)
>
> Does anybody reacll why
>               * FIXME: if cacheDir is for example $USER_HOME and they have a
> folder called http
>               * and/or https. These would get removed.
>               */
>              remove.add(cacheDir + File.separator + "http");
>              remove.add(cacheDir + File.separator + "https");
>
> do exists?

This case has become obsolete since IcedTea-Web's support for XDG. I assume this 
FIXME has been added for when XDG is not supported on the target system. So the 
user may have "http" and/or "https" sub-directories in their $HOME directory 
(although improbable but possible). As I understand, currently these 
sub-directories get removed unconditionally which may lead to unintended loss of 
data for some users, hence the FIXME. So, further code needs to be added to 
selectively and safely delete files in those sub-directories on systems which do 
not support XDG.

Indeed, software should never /delete/ files it has not written itself (except 
for file managers, of course), in order to minimize the possibility of losing 
data unintentionally.

Jacob