[rfc][icedtea-web][policyeditor] Copy Paste refactored to use System Clipboard

[Jie Kang]

----- Original Message -----
> Hello,
> 
> > I would make the error message for failing to paste a little more
> > descriptive. Right now I see "Could not read policy entry for codebase
> > null". I suggest something like "Paste failed: System clipboard does not
> > contain a valid codebase entry" Or something that let's the user know that
> > the paste failed because they are trying to copy something that isn't
> > acceptable.
> 
> Okay changed so the dialog to now display "Paste Failed: Could not read
> policy
> entry for codebase {0} from system clipboard".
> 
> > Also maybe for another patch, I would make it possible to paste one
> > codebases' properties to another. Atm if you try to paste to a codebase
> > that
> > already exists, nothing happens and the dialog reappears. I think it would
> > be good to instead have it override the properties of the existing
> > codebase.
> > Or have a selection to allow overriding.
> 
> Great Suggestion, I'm thinking maybe a Ctrl+Shift+V would copy only the
> properties.
> I will look into this as a future patch.
> 
> > When doing user testing, I repeatedly attempted to paste an invalid entry
> > from the system clipboard. When closing the program there some exceptions
> > spouted out which may or may not be an issue. I have attached the logs. It
> > seems that each failure to paste from system clipboard does not fully
> > complete until the policyeditor closes at which point it spews out it's
> > exceptions. Something like that :/
> 
> I have not been able to reproduce this, but that might be because of the
> latest
> pushes. If you still find this issue in the up to date repo, then I will
> look into this further.
> 

Yeah as of latest pushes I can't reproduce it either.


Patch looks good. +1


> Thank you,
> Lukasz Dracz
> 

-- 

Jie Kang