[rfc][icedtea-web] Fix handling of UI controls in Java console

[Jiri Vanek]

On 07/01/2014 04:33 PM, Jiri Vanek wrote:
> On 07/01/2014 04:29 PM, Jacob Wisor wrote:
>> On 07/01/2014 11:36 AM, Jiri Vanek wrote:
>>> On 06/28/2014 11:56 PM, Jacob Wisor wrote:
>>>> Hello there!
>>>>
>>>> The subject says it all. ;-)
>>>>
>>>> Jacob
>>>
>>>
>>> No objections - only one really minor nitpick. When logs cross over several
>>> thousands, they can get slow.
>>
>> Yes, but this a problem of the log's JTextField and has nothing to with setting the enabled state of
>> JCheckBoxes. I have thought of it to. The log should probably be limited to something like 1000
>> lines or a configurable count.
>>
>>> Then the feature  of - hide all messages/headers , then set desired parts and
>>> then show messages/headers again, was quite useful.  So think about this
>>> disabling/enabling before push - well the disabling/enabling looks at least
>>> cooler then it was without (and As I know you, I would easily guess the reasons
>>> for it :) )
>>
>> I think it is OK.
>> What bothers me more are those many anonymous classes in ConsoleOutputPane, spawning as many object
>> at runtime. So, this is why I thought you might request that the JCheckBoxes' enabled state to be
>> handled in separate anonymous classes as well. What do you think? Dispatching to distinct listeners
>> is faster at runtime but requires more storage space and memory at runtime. Using a shared listener
>> is a little bit slower on dispatching but requires less storage space and less memory at runtime.


Hmm. I have just got to this. There is only abut 10 anonymus classes per ConsoleOutputPane. Its not 
so bad considering tha one have usually only one console in one netx instance.

Can you point which a.classes you wont to get rid?

J.
>
> Yah I'm aware of this.  And I feel a bit uncomfortable about this. This shared listener sounds like
> an good idea to me.
>
> As for te limit, I'mnot fan of it. There is "clear mesages" button. And it should serve its purpose.
> Also by default console is hidden. That means that no lines are rocessed. AFAIK there is absolutely
> no performance drop with hidden console.
>
> But reducing of the huge number of anonymous classes is definitively worthy to try.
>
>
>
> J.