[rfc][icedtea-web] Resource Status Rename (super small patch)

Jie Kang jkang at redhat.com
Tue Aug 19 20:09:46 UTC 2014



----- Original Message -----
> On 08/15/2014 08:56 PM, Jie Kang wrote:
> > Hello,
> >
> > When studying the ResourceTracker I found the Status names and what they
> > meant were not completely obvious. I have changed the names:
> >
> > Connect -> Preinitialize  and Download -> Predownload
> >    The new names are more informative of the resources state.
> >
> > Connecting -> Initializing Connected -> Initialized
> >
> > The connect->connecting->connected state refers to the process of
> > initializing the resource. A connection does occur within initializing but
> > there is much more being done than that. As such I think the name
> > preinitialize -> initializing -> initialized is more accurate.
> 
> Nevertheless, your renaming proposal completely dumps the notion of
> connecting
> to or for a resource, which is quite essential to this whole concept. Perhaps
> you could try again and still incorporate the "connect" term? Maybe you could
> add one or two new states with additional code to make things more clear?

Hello,

As the alternative I suggest Preconnect->Connecting->Connected. Thoughts?

Patch attached.


Regards,

> 
> > Started -> Processing
> >    The STARTED state afaik means that the resource is either currently
> >    connecting, or downloading, or in queue waiting to be connected and/or
> >    downloaded. I think Processing is more informative than started.
> >
> > Of course when I wrote this patch I feel like the easiest response against
> > is that there isn't much point to changing the names but I think it's
> > helpful to have code that is quickly understandable.
> 
> Indeed, as many even wiser people than me have noted, naming in computer
> science
> is very important and a considerable amount of effort should be put into it
> when
> developing software or creating concepts. Unfortunately, the world does not
> always work like this. This is why there are some great pieces of software
> out
> there with great concepts sometimes solving real problems but suffer from
> terrible nomenclature. Naming is indeed important. So, +1 for your effort.
> 
> Jacob
> 

-- 

Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-res-status-rename-1.patch
Type: text/x-patch
Size: 14066 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140819/3f237c34/itw-res-status-rename-1.patch>


More information about the distro-pkg-dev mailing list