[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space

[Jacob Wisor]

On 07/29/2014 03:41 PM, Lukasz Dracz wrote:
> Hello,
>
>> Nice patch. Just a minor nit with the import statements:
>>
>> +import javax.swing.*;
>> +import javax.swing.event.ChangeEvent;
>> +import javax.swing.event.ChangeListener;
>> +import java.awt.*;
>>
>> Instead of importing the whole library please replace these with only the
>> imports of specific classes that you need.
>>
>
> Ah yes, sorry about that my IDE autoformats oddly, I have changed it back to the way it was,
> the imports that are removed are unused imports.
>
>> Jie Kang
>
> Thank you,
> Lukasz Dracz

Overall, the patch is moving in the right direction. But, there are things which 
need more attention.

The "Limit cache size" JCheckBox should be located over the JSpinner's label. 
Then, the JSpinner's label could use some indentation but this may become tricky 
with rtl scripts so just leave it there for now. ;-)

When the "Limit cache size" JCheckBox is unchecked it the JSpinner's label 
should also be set to disabled state. Some window managers and/or design themes 
change the colors of disabled labels too.

The "Maximum" label is superfluous and adds no reasonable information to the 
user. Quite the opposite, it is more confusing than clarifying. The JSpinner 
stops incrementing when hitting Long.MAX_VALUE anyway.

The "Available" label should probably have a unit indicator too.

The label warning about the value in the JSpinner being larger than available 
disk space should run over the entire width of the JSpinner's label + the width 
of the JSpinner itself. Or, be put into a status bar.

Although using different colors for specific levels of urgency in the JSpinner 
seems to be a good idea at first, they are utterly depended on the user's 
current theme design. Namely, it depends on the JSpinner's background to be 
white or black. Especially users suffering from daltonism may have problems 
reading those numbers, which is why they are probably going to use high contrast 
design themes in the first place. Setting colors explicitly here may be 
contradicting its usefulness. So, it is probably best to go with the default 
colors here. Or, you devise a scheme which works across all design theme color 
ranges.
Another plausible approach would be to exchange default text and background 
colors when going over available disk space.

Steps should not jump to power of 2! Accelerating magnitudes are the deal here. 
;-) Again, it is best to start with 1 and accelerate over magnitudes (powers of 10).

Jacob