[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space

[Lukasz Dracz]

Hello,

> Now it works. My humble opinion about the patch:
> 
> The spinner works great...this seem to be a good approach.
> 
> Limit cache size checkbox should be before the text/spinner.

Okay.

> Why available>maximum?

Available shouldn't be larger than maximum, for me available it is 685,392, and Maximum should be 2,147,483,648 which is MAX_VALUE of Integer.

> Can maximum be rounded to MB?

All Values were/are in MB, which makes Maximum a ridiculously large number.

> I dont like "colored text" very much: people with dissabilities/color blind
> could even confuse them.
> Why orange?...I understand the red, but why 32MB is orange? (btw, I cannot
> CLEARLY see it [Im one of those])

Yes, Sorry for not taking that into account, along with the issues in various themes that Jacob mentioned, I think it is much better to just avoid setting colours.

> The default window is smaller and a scrollbar appears.

I put it into a scroll pane so on smaller resolution screens or when resized to a smaller size you could still be able to navigate within the cache panel, the smaller size for the default window I believe was from another patch.
 
> 
> In general, I dont like the GUI/layout, what about something like:
> 
> Temporary Internet Files
> Java stores application data for faster execution the next time you run it
> Limit cache size: <spinner> MB (0=dont cache)  [all the following disabled
> if limit is = 0]
>     [show warning here when needed]
> Compresion level <select>
> Location <change>
> <view files>

I like this new layout and have used it.

>The "Available" label should probably have a unit indicator too.

Added MB.

For the colours as mentioned got rid of it, thanks ! I

>Steps should not jump to power of 2! Accelerating magnitudes are the deal here.
>;-) Again, it is best to start with 1 and accelerate over magnitudes (powers of 10).

I much liked the powers of 2 but I guess 10 might be a better choice :)

>The "Maximum" label is superfluous and adds no reasonable information to the user.

Got rid of it.

>The "Limit cache size" JCheckBox should be located over the JSpinner's label. 

Done.

Thanks for the review Jacob. Hope you had a great holiday helpcrypto and thanks for the review.

Regards,
Lukasz Dracz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cacheSizeSpinner-10.patch
Type: text/x-patch
Size: 18046 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140826/a1afd577/cacheSizeSpinner-10-0001.patch>