[rfc][icedtea-web] Option Parser
Jiri Vanek
jvanek at redhat.com
Wed Aug 27 10:38:50 UTC 2014
Hello.
Many other nits. Omair already brought most important up, but I have still some more in mind. Where
Omair's thought fight with my, please his have advantage.
Few general thoughts. Your first patch had much cleaner design then this second. When trying to
listen to reviwers, someties you need to change concept generally. Otherwise you will end up with
solution like now - partially yours, but to bent by review.
On 08/25/2014 10:32 PM, Lukasz Dracz wrote:
> Hello,
>
> Here is the updated patch based on most of your suggestions.
>
>> >Just to be clear, this patch changes behaviour too, right?
> I suppose your right, I tried my best not to, but some parts were changed.
>
>>> >> private static final String doubleArgs = "-basedir -jnlp -arg -param -property -update";
>> >Is this variable used any more?
> It was in getJNLPFile but I rewrote that part too in this updated patch. So it is gone now.
>
>> >Code like this is a hint that maybe you should have called your class ArgumentParser
> Haha you are right, but since I added Option interface and OptionParser Config enum, I changed the name to optionParser instead.
>
>> >Would it be easier to read this code if checkOption was renamed to
>> >hasOption? I can't quite figure out (just by looking at the method name)
>> >what check it is performing.
> Thank you ! checkOption looked weird to me as well at the time but I couldn't think of anything that wasn't too verbose (checkForOption, checkForTheOption :P).
>
>> >I am not a fan of comments, but in cases like this, it is probably a
>> >good idea to comment on the style of options it parses (--style or
>> >-style). Maybe also add a note for developer on how to add support for
>> >more options?
> Added better comment.
>
>> >Also small typo nit that I think came from my own mistake x_x:
> I did not notice it at the time either, changed :)
>
>> >You need to get rid of doubleArgs,
> Gone, had to rewrite getJNLPFile.
>
>> >and of thet terrible Enum.
> Your not going to like me, I kept the Enum but I put it somewhere else.
>
> Why is it a terrible Enum ?
>
>> >I would suggest you to change
>> >public OptionParser(String[] args)
>> >
>> >to
>> >
>> >public OptionParser(String[] args, OptionParserConfig cfg)
> Good idea, done.
>
> Jiri, I implemented it a little differently than you suggested, and was wondering what your thoughts on it are. (as well as Omair's, Jie and anyone else's too :) ) I made an enum that holds the config you decide to use that will be passed into the Option Parser. The enum you choose references an Enum which holds all the possible options for the config (that must implement interface Option to be compatible with the Option Parser). If you feel it should still be implemented more in the way you suggested, I will convert it to work in that way.
>
> Also I have Placeholder Enums for ITWSettings and PolicyEditor Options as I will have a look into those later. I will not push those, but add them in a later patch when/if they are done.
>
> Thanks for the suggestions Omair, Jiri and Jie !
>
> Regards,
> Lukasz Dracz
>
>
>
>
>
> OptionParser-5.patch
>
>
> diff -r c45cd47e962b netx/net/sourceforge/jnlp/runtime/Boot.java
> --- a/netx/net/sourceforge/jnlp/runtime/Boot.java Wed Aug 20 15:49:58 2014 -0400
> +++ b/netx/net/sourceforge/jnlp/runtime/Boot.java Mon Aug 25 16:04:08 2014 -0400
> @@ -22,7 +22,6 @@
> import java.net.URL;
> import java.security.AccessController;
> import java.security.PrivilegedAction;
> -import java.util.ArrayList;
> import java.util.Arrays;
> import java.util.HashMap;
> import java.util.List;
> @@ -39,7 +38,10 @@
> import net.sourceforge.jnlp.config.DeploymentConfiguration;
> import net.sourceforge.jnlp.security.viewer.CertificateViewer;
> import net.sourceforge.jnlp.services.ServiceUtil;
> +import net.sourceforge.jnlp.util.optionparser.JavaWSOption;
> +import net.sourceforge.jnlp.util.optionparser.OptionParser;
> import net.sourceforge.jnlp.util.logging.OutputController;
> +import net.sourceforge.jnlp.util.optionparser.OptionParserConfig;
> import sun.awt.AppContext;
> import sun.awt.SunToolkit;
>
> @@ -123,26 +125,24 @@
> + " -Xoffline " + R("BXoffline") + "\n"
> + " -help " + R("BOHelp") + "\n";
>
> - private static final String doubleArgs = "-basedir -jnlp -arg -param -property -update";
> -
> - private static String args[]; // avoid the hot potato
> -
> + private static OptionParser optionParser;
> /**
> * Launch the JNLP file specified by the command-line arguments.
> */
> public static void main(String[] argsIn) {
> - args = argsIn;
>
> + OptionParserConfig optionParserConfig = OptionParserConfig.JAVAWS;
> + optionParser = new OptionParser(argsIn, optionParserConfig);
I think that
optionParser = new OptionParser(argsIn, OptionParserConfig.JAVAWS;);
is enough
> if (AppContext.getAppContext() == null) {
> SunToolkit.createNewAppContext();
> }
> - if (null != getOption("-headless")) {
...snip
> - if (null != getOption("-update")) {
> - int value = Integer.parseInt(getOption("-update"));
> - JNLPRuntime.setDefaultUpdatePolicy(new UpdatePolicy(value * 1000l));
> + if (optionParser.hasOption(JavaWSOption.UPDATE)) {
> + try {
> + int value = Integer.parseInt(optionParser.getOptionValues(JavaWSOption.UPDATE)[0]);
> + JNLPRuntime.setDefaultUpdatePolicy(new UpdatePolicy(value * 1000l));
> + } catch (NumberFormatException NFE) {
> + }
I thnk this logic can be hidden. It is behaviour of this option that it have integert value.
Validator? getter?
To this you may have smethin like
Option
String getValue
validateValue() throws ValidatorException
IntegerOption extends Option
with new int getValueAsInt, with conversion
and with overriden validator
or simialr concept.
This isf for objects are...
> }
>
> - if (null != getOption("-noupdate"))
> + if (optionParser.hasOption(JavaWSOption.NOUPDATE))
> try {
> Launcher launcher = new Launcher(false);
> @@ -296,63 +299,21 @@
> * Gets the JNLP file from the command line arguments, or exits upon error.
> */
> private static String getJNLPFile() {
> + if (optionParser.getArgsLength() == 1) {
> + return optionParser.getArgs()[0];
> + } else if (optionParser.hasOption(JavaWSOption.JNLP)) {
> + return optionParser.getOptionValues(JavaWSOption.JNLP)[0];
Oh no.... Please hide the array.
Is param really expected to have more values?
If so, you need somewherre getValues - whichreturn list or aray or whatever, and getValue(int id)
How You will deal with it is upto yuou.
I would go with MultipleValuesOption extensionin similar way as IntegerOption above.
> + } else {
> + List<JavaWSOption> secondLastArg = Arrays.asList(JavaWSOption.BASEDIR, JavaWSOption.ARG, JavaWSOption.PARAM, JavaWSOption.PROPERTY, JavaWSOption.UPDATE);
This is really very very nasty. Only nastier thing is place where it is.
How itw is handling those... "last args" is really terrible. Once you have claimed to fix
Optonparser, it is time to fix this.
Normal argument processing should look like
comamnd -param value -param=value -paramNovalue mainArgument -anotherNoValueParam -param=value
... (yes good habit is to have tha mainArg as last, but it shold not cause fall)
So your parser always know how to deal with those values. And if he does not know, then it have tobe
the "mainArgument" . If there is more mainArguments then it is wrong, user should be warned.
Appthen should die (or continue with randomone?)
Some apps - eg texteditors - takes more mainArgs - they then opem more files.
AFAIK ITW do nto do this :) javaws takes as last argument jnlpfile, Not sure about itwsettings and
policyeditor (I guess these have no "main argument",nut pelase double check.
> + for (JavaWSOption option : secondLastArg) {
> + if(optionParser.getArgs()[optionParser.getArgsLength()-2].equals(option.toString())) {
> + return optionParser.getArgs()[optionParser.getArgsLength()-1];
> + }
...snip...
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +public enum ITWSettingsOption implements Option {
> + TODO("-NeedToImplement");
please dont do this.
1) no todo here
2) lets have all otpions same syntax.
Your OptionClass should be powerfull enough to handle it.
> +
> + private String value;
> +
> + private ITWSettingsOption(String value) {
> + this.value = value;
> + }
> +
> + @Override
> + public String toString() {
> + return this.value;
> + }
> +}
> \ No newline at end of file
...
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +public enum JavaWSOption implements Option{
> + BASEDIR("-basedir"),
> + JNLP("-jnlp"),
> + ARG("-arg"),
> + PARAM("-param"),
> + PROPERTY("-property"),
> + UPDATE("-update"),
> + HEADLESS("-headless"),
> + VIEWER("-viewer"),
> + VERSION("-version"),
> + LICENSE("-license"),
> + HELP("-help"),
> + ABOUT("-about"),
> + VERBOSE("-verbose"),
> + NOUPDATE("-noupdate"),
> + NOFORK("-Xnofork"),
> + TRUSTALL("-Xtrustall"),
> + TRUSTNONE("-Xtrustnone"),
> + OFFLINE("-Xoffline"),
> + NOSECURITY("-nosecurity"),
> + CLEARCACHE("-Xclearcache"),
> + IGNOREHEADERS("-ignoreheaders"),
> + ALLOWREDIRECT("-allowredirect");
One FutureFeature nit.
In javaws manpage, the params ffor jaaws are splited like:
Control Options
...
-about Shows about dialog.
-viewer Shows the trusted certificate viewer. This allows a user to
...
Run Options
...
-version Prints out v
well the rest...
It would be nice to allow similar split in implementation.
eg
public enum JavaWsControlOptions implements Option
public enum JavaWsRuntimeOption implements Option
public enum JavaWsOption = JavaWsControlOptions+JavaWsRuntimeOptions;
pleas note the cammelcase Ws
> +
> + private String value;
> +
> + private JavaWSOption(String value) {
> + this.value = value;
> + }
> +
> + @Override
> + public String toString() {
> + return this.value;
> + }
> +
> +}
> \ No newline at end of file
> diff -r c45cd47e962b netx/net/sourceforge/jnlp/util/optionparser/Option.java
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/netx/net/sourceforge/jnlp/util/optionparser/Option.java Mon Aug 25 16:04:08 2014 -0400
...
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +public interface Option {
> +
> +}
Ok whats that?
It do not have any sense at all.
This approach - enum only is wrong.
Iwould strngly prefere to have one and good Optiondeclaration
- param
- possibel values description
- human redable description (reusabel in help or similar human readable outputs)
so
+public enum JavaWSOption implements Option{
+ BASEDIR("-basedir", "human redable dexcription", valuesSettings),
The values settings may lead to sublasing, but I think it will be much more preferable.
> diff -r c45cd47e962b netx/net/sourceforge/jnlp/util/optionparser/OptionParser.java
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/netx/net/sourceforge/jnlp/util/optionparser/OptionParser.java Mon Aug 25 16:04:08 2014 -0400
> @@ -0,0 +1,116 @@
> +/*Copyright (C) 2014 Red Hat, Inc.
> +
...
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +
> +import java.util.ArrayList;
> +import java.util.Arrays;
> +import java.util.List;
> +
> +/** Parses for options (passed in as arguments)
> + * To use make an enum that implements Option,
> + * and add a new enum value to OptionParserConfig
> + * that refers to your new set of Options
> + * For an example, see JavaWSOption
> + */
> +public class OptionParser {
I would rewrote the old approach parsing options for each get.
You may have factory method, which will parse the args only once,
Options opts = OptionParser.parse(args,soemConfigEgJavawsOptions)
In Options you have then only list of parsed values.
> +
> + private String[] args;
> + private OptionParserConfig optionParserConfig;
> +
> + public OptionParser(String[] args, OptionParserConfig option) {
> + this.args = Arrays.copyOf(args, args.length);
> + this.optionParserConfig = option;
> + }
> +
> + public String[] getArgs() {
> + return Arrays.copyOf(args, args.length);
> + }
> +
> + private boolean isOption(String s) {
> + for(Option opt : optionParserConfig.getOptionsList()){
> + if (opt.toString().equals(s)) {
> + return true;
> + }
> + }
> + return false;
> + }
> +
> + public boolean hasOption(Option option) {
> + if (optionParserConfig.isSameClass(option)) {
> + for (String str : args) {
> + if (option.toString().equals(str)) {
> + return true;
> + }
> + }
> + }
> + return false;
> + }
> +
> + public int getArgsLength() {
> + return args.length;
> + }
> +
> + /**
> + * Return all the values of the specified option, or an empty
> + * array if the option is not present. If the option is
> + * present with no parameters then the option name is
> + * returned once.
> + */
> + public String[] getOptionValues(Option option) {
> + List<String> result = new ArrayList<String>();
> + if (optionParserConfig.isSameClass(option)) {
> + int i = 0;
> + while (i < args.length) {
> + if (isOption(args[i]) && option.toString().equals(args[i])) {
> + i++;
> + while (i < args.length && !isOption(args[i])) {
> + result.add(args[i]);
> + i++;
> + }
> + if (result.size() == 0) {
> + result.add(option.toString());
> + }
> + } else {
> + i++;
> + }
> + }
> + }
> +
> + return result.toArray(new String[result.size()]);
> + }
> +}
> diff -r c45cd47e962b netx/net/sourceforge/jnlp/util/optionparser/OptionParserConfig.java
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/netx/net/sourceforge/jnlp/util/optionparser/OptionParserConfig.java Mon Aug 25 16:04:08 2014 -0400
> @@ -0,0 +1,66 @@
> +/*Copyright (C) 2014 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +import java.util.ArrayList;
> +import java.util.EnumSet;
> +import java.util.List;
> +import java.util.Collection;
> +
> +public enum OptionParserConfig {
> + JAVAWS(JavaWSOption.class),
> + POLICYEDITOR(PolicyEditorOption.class),
> + ITWSETTINGS(ITWSettingsOption.class);
> +
> + Class theClass;
> + private <E extends Enum<E>> OptionParserConfig(Class<E> e){
> + this.theClass = e;
> + }
> +
> + public List<Option> getOptionsList() {
> + return new ArrayList<Option>((Collection<? extends Option>) EnumSet.allOf(theClass));
> + }
> +
> + public boolean isSameClass(Option option){
> + if(option.getClass() == theClass)
> + {
> + return true;
> + }
> + return false;
> + }
Clsoe enough, but probably to complex.
> +
> +}
> \ No newline at end of file
> diff -r c45cd47e962b netx/net/sourceforge/jnlp/util/optionparser/PolicyEditorOption.java
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/netx/net/sourceforge/jnlp/util/optionparser/PolicyEditorOption.java Mon Aug 25 16:04:08 2014 -0400
> @@ -0,0 +1,53 @@
> +/*Copyright (C) 2014 Red Hat, Inc.
> +
>...
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +public enum PolicyEditorOption implements Option{
> + TODO("-NeedToImplement");
> +
> + private String value;
> +
> + private PolicyEditorOption(String value) {
> + this.value = value;
> + }
> +
> + @Override
> + public String toString() {
> + return this.value;
> + }
> +
Same as th itwoption. No need for existence.
> +}
> \ No newline at end of file
> diff -r c45cd47e962b tests/netx/unit/net/sourceforge/jnlp/util/optionparser/OptionParserTest.java
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/tests/netx/unit/net/sourceforge/jnlp/util/optionparser/OptionParserTest.java Mon Aug 25 16:04:08 2014 -0400
> @@ -0,0 +1,214 @@
> +/*Copyright (C) 2014 Red Hat, Inc.
> +
> +This file is part of IcedTea.
> +
> +IcedTea is free software; you can redistribute it and/or
> +modify it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, version 2.
> +
> +IcedTea is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with IcedTea; see the file COPYING. If not, write to
> +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> +02110-1301 USA.
> +
> +Linking this library statically or dynamically with other modules is
> +making a combined work based on this library. Thus, the terms and
> +conditions of the GNU General Public License cover the whole
> +combination.
> +
> +As a special exception, the copyright holders of this library give you
> +permission to link this library with independent modules to produce an
> +executable, regardless of the license terms of these independent
> +modules, and to copy and distribute the resulting executable under
> +terms of your choice, provided that you also meet, for each linked
> +independent module, the terms and conditions of the license of that
> +module. An independent module is a module which is not derived from
> +or based on this library. If you modify this library, you may extend
> +this exception to your version of the library, but you are not
> +obligated to do so. If you do not wish to do so, delete this
> +exception statement from your version.
> + */
> +
> +package net.sourceforge.jnlp.util.optionparser;
> +
> +import static org.junit.Assert.assertArrayEquals;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertTrue;
> +
> +
> +import org.junit.Test;
> +import java.util.Arrays;
> +
> +public class OptionParserTest {
> +
> + OptionParserConfig optionParserConfig = OptionParserConfig.JAVAWS;
> +
> + @Test
> + public void testGetSingleOptionValue() {
> + String[] args = {"-basedir", "blob"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> +
> + assertEquals("blob", values[0]);
> + assertEquals(1, values.length);
> + }
> +
> + @Test
> + public void testGetSingleOptionMultipleValues() {
> + String[] args = {"-basedir", "blob", "meow"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals("blob", values[0]);
> + assertEquals("meow", values[1]);
> + assertEquals(2, values.length);
> + }
> +
> + @Test
> + public void testGetDifferentOptionValues() {
> + String[] args = {"-basedir", "blob", "-arg", "help"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals("blob", values[0]);
> + assertEquals(1, values.length);
> +
> + values = parser.getOptionValues(JavaWSOption.ARG);
> + assertEquals("help", values[0]);
> + assertEquals(1, values.length);
> +
> + }
> +
> + @Test
> + public void testUnsupportedOptionValue() {
> + String[] args = {"-unsupported", "blob"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals(0, values.length);
> + }
> +
> + @Test
> + public void testSupportedOptionValueWithNoUse() {
> + String[] args = {};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals(0, values.length);
> + }
> +
> + @Test
> + public void testOptionValueWithNoArgument() {
> + String[] args = {"-basedir"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals("-basedir", values[0]);
> + assertEquals(1, values.length);
> + }
> +
> + @Test
> + public void testOneOptionMultipleTimesMultipleValues() {
> + String[] args = {"-basedir", "poke", "blob", "-basedir", "meep"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals(3, values.length);
> + assertEquals("poke", values[0]);
> + assertEquals("blob", values[1]);
> + assertEquals("meep", values[2]);
> + }
> +
> + @Test
> + public void testMultipleOptionsMultipleValues() {
> + String[] args = {"-basedir", "poke", "blob", "-param", "meep"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals(2, values.length);
> + assertEquals("poke", values[0]);
> + assertEquals("blob", values[1]);
> + values = parser.getOptionValues(JavaWSOption.PARAM);
> + assertEquals(1, values.length);
> + assertEquals("meep", values[0]);
> + }
> +
> + @Test
> + public void testCheckOptionExists() {
> + String[] args = {"-basedir", "-fish", "-castle", "boat"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + boolean value = parser.hasOption(JavaWSOption.BASEDIR);
> + assertTrue(value);
> + }
> +
> + @Test
> + public void testCheckOptionExistsAsNotFirstArg() {
> + String[] args = {"-run", "fish", "-castle", "-basedir"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + boolean value = parser.hasOption(JavaWSOption.BASEDIR);
> + assertTrue(value);
> + }
> +
> + @Test
> + public void testCheckOptionNotExists() {
> + String[] args = {"-run", "fish", "-castle", "cat"};
> + OptionParser parser = new OptionParser(args, optionParserConfig);
> +
> + boolean value = parser.hasOption(JavaWSOption.BASEDIR);
> + assertFalse(value);
> + }
> +
> + @Test
> + public void testGetArgs() {
> + String[] args1 = {"-run", "fish", "-castle", "cat"};
> + OptionParser parser = new OptionParser(args1, optionParserConfig);
> +
> + String[] args2 = parser.getArgs();
> +
> + assertEquals(args1.length, args2.length);
> + assertArrayEquals(args1, args2);
> + }
> +
> + @Test
> + public void testGetArgsCantModifyValue() {
> + String[] args1 = {"-run", "fish", "-castle", "cat"};
> + OptionParser parser = new OptionParser(args1, optionParserConfig);
> + args1[0] = "prince";
> + String[] args2 = parser.getArgs();
> +
> + assertEquals(args1.length, args2.length);
> + assertFalse(Arrays.equals(args1, args2));
> + }
> +
> + @Test
> + public void testDifferentOptionParserConfigsDoNotConflict() {
> + OptionParserConfig optionParserConfig1 = OptionParserConfig.POLICYEDITOR;
> +
> + String[] args = {"-basedir", "blob"};
> + OptionParser parser = new OptionParser(args, optionParserConfig1);
> +
> + String[] values = parser.getOptionValues(JavaWSOption.BASEDIR);
> + assertEquals(0, values.length);
> + }
> +
> + @Test
> + public void testHasOptionReturnsFalseForDifferentOptionParserConfig() {
> + OptionParserConfig optionParserConfig1 = OptionParserConfig.POLICYEDITOR;
> +
> + String[] args = {"-basedir", "-Xnofork"};
> + OptionParser parser = new OptionParser(args, optionParserConfig1);
> +
> + assertFalse(parser.hasOption(JavaWSOption.NOFORK));
> + assertFalse(parser.hasOption(JavaWSOption.BASEDIR));
> + }
> +
> +}
>
More information about the distro-pkg-dev
mailing list