[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space

[Jacob Wisor]

On 08/29/2014 06:20 PM, Lukasz Dracz wrote:
> Hello,
>
>> Hmm...Is not exactly what I was thinking.
>> If you find the following layout better, I'll be happy if its applied.
>>
>> PS: I think you messed the hide/show stuff...and with limit unchecked I
>> cant see the jar compression either!
>
> For me the hide/show was working, but after some further testing I found that when initializing the settings it would not show the proper setup based on what values you had saved. I believe I fixed it, if you still have an issue I'll look into it more.
>
>> --------------------
>> Java stores application data in cache for faster execution the next time
>> you run it.
>>
>> (Notice theres not tittledborder!)
>
> Yeah good idea. I also got rid of the horizontal line.

You may get rid of the horizontal line but the "Java stores application data..." 
descriptive text should get pushed to the top for consistency with other dialog 
pages.

>> <check> Limit cache usage. Maximum cache in MB: <spinner>
>> ("Maximum cache in MB"+spinner will be hidden if limit unchecked)
>> <warning>
>> (If limit=0 or limit>available, warning goes here, otherwise hidden)
>> Jar compression level
>> <select>                                                            (this
>> must be hidden only if limit=0)
>> Location where temporary files are
>> stored:                                            (this
>> label+<path>+<change>+<view files> are hidden only if limit=0)
>> <path> <change> <view files>
>> --------------------
>
> Yeah this layout looks much better.

Yes, the overall layout looks better.

> Also I changed the max from 2,147,483,648 to 2,147,483,647 since I found that value was actually out of bounds for the deployment config cache size.

No no, do not start playing around with visible and hidden UI components. It is 
even worse when they change their layout or start jumping around like it is now. 
Generally, there is never any need to hide UI components. If there seems to be, 
then either there is something wrong with the basic design of a window or 
dialog, or you should have very good reasons to do so. And, in this case there 
is surely *no* reason to hide any components dynamically at all. Again, stick to 
disabling components. This should be enough.

@helpcrypto
Yes, it is against basic UI design principles to have hiding UI components, 
unless there are really good reasons to do so. Please do not start giving advice 
on something you do not know or have no experience in. This only confuses young 
or new developers.

Unfortunately, because of your attempt to play around with hiding UI components 
you have introduced a new bug. When "Limit cache size" is checked and the 
spinner is 0 then all components for setting up the cache location suddenly 
disappear. And, as soon as the value becomes greater than 1, they become visible 
again. This is very odd, weird, and confusing. Again, do not play around with 
hiding UI components.

Please also change the spinner's step size either to 1 or accelerating 
magnitudes of 10. There is no need to confuse users with powers of 2!

Jacob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cache limit.png
Type: image/png
Size: 38231 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140830/4a95088a/cachelimit-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no cache limit.png
Type: image/png
Size: 41188 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140830/4a95088a/nocachelimit-0001.png>