[rfc][icedtea-web] Add last-modified information to TinyHttpdImpl

Jiri Vanek jvanek at redhat.com
Fri Dec 5 17:25:17 UTC 2014


On 12/02/2014 05:15 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> On 11/27/2014 10:07 PM, Jie Kang wrote:
>>> Hello,
>>>
>>> This patch adds the Last-Modified field to responses from our reproducer
>>> server TinyHttpdImpl. This allows for reproducers to also test the
>>> re-download system that we currently have in Icedtea-Web, which uses the
>>> last-modified field to determine whether or not to download things again.
>>>
>>> Thoughts?
>>>
>>>
>>> Regards,
>>>
>> hi!
>>
>> This is good idea. However I would like to add getter/setter for flag, which
>> will allow to enable/disable adding of this header param.
>>
>> And by default have it off, and enable it on demand, when some test is
>> testing redownloading. What do you think?
>
> Hello,
>
> I've attached a patch that does what I think you mean. Does it look right?

yy, go on and push.

Are you going to add some tests which will test how our caching is working when used against this 
new header entry?
>
>
> Also, I am curious, why would you like it to be off by default?

Because whole reprodcuers framework is/may be depending on it.(?)  (eg XslowX ?)
And it does not mean that it will be turned on later...
>

Thanx for this!
   J.



More information about the distro-pkg-dev mailing list