[rfc][icedtea-web] bringing applets out of browser (part1)

[Jiri Vanek]

On 12/17/2014 09:16 AM, Jacob Wisor wrote:
...
>>
>> Hm:( If you wont something like:
>>
>>    -           s.append("  </applet-desc>\n");
>>    -            s.append("</jnlp>\n");
>>    +           s.append("  </applet-desc>\n</jnlp>\n");
>>
>> Then I'm quite against. The original paragraphs seems much more readable to me:(
>
> Well, you can still do this:
>
> -           s.append("  </applet-desc>\n");
> -           s.append("</jnlp>\n");
> +           s.append("  </applet-desc>\n" +
> +                    "</jnlp>\n");
>
> This is how you do multi-line strings in Java. It works because final (or literal) string concatenations are processed at compile-time by the compiler. In your example, the string is concatenated or rather built (appended) by StringBuilder at run-time. These two notations are functionally equivalent but do have a different impact at run-time.


Well. why not then :)


I will include it into next iteration in reply to Jie.

ty!

  J.
>
>>
>>> Also, please concatenate the append operations with the derefenrence operator where possible. You can still group the
>>> string building process into logical chunks using line breaks for better readability. ;-) This produces much better code
>>> quality utilizing the stack which leads to higher performance. StringBuilder and the append() method have been developed
>>> exactly for this kind of purpose.
>>
>> Yah! Fixed. thank you for this reminder!
>>
>>
>> Shortly:
>>
>> public String toJnlp(boolean needSecurity, boolean useHref, boolean fix) {
>> +        if (useJNLPHref && debugJnlp != null && useHref) {
>> +            OutputController.getLogger().log("Using debugjnlp as return value toJnlp");
>> +            if (fix) {
>> +                return fixCommonIsuses(needSecurity, debugJnlp);
>> +            } else {
>> +                return debugJnlp;
>> +            }
>> +        } else {
>> +            StringBuilder s = new StringBuilder();
>> +            s.append("<?xml version='1.0' encoding='UTF-8'?>\n")
>> +                    .append("<jnlp codebase='").append(getCodeBase().toString()).append("'")
>> +                    .append(">\n")
>> +                    .append("  <information>\n")
>> +                    .append("    <title>").append(createJnlpTitle()).append("</title>\n")
>> +                    .append("    <vendor>").append(createJnlpVendor()).append("</vendor>\n")
>> +                    .append("  </information>\n");
>> +            if (needSecurity) {
>> +                s.append(getSecurityElement());
>> +            }
>> +            s.append("  <resources>\n");
>> +            for (String i : getArchiveJars()) {
>> +                s.append("    <jar href='").append(i).append("' />\n");
>> +            }
>> +            s.append("  </resources>\n")
>> +                    .append("  <applet-desc\n")
>> +                    .append("    name='").append(getTitle()).append("'\n")
>> +                    .append("    main-class='").append(getStrippedMain()).append("'\n")
>> +                    .append("    width='").append(getApplet().getWidth()).append("'\n")
>> +                    .append("    height='").append(getApplet().getHeight()).append("'>\n");
>> +            if (!getApplet().getParameters().isEmpty()) {
>> +                Set<Map.Entry<String, String>> prms = getApplet().getParameters().entrySet();
>> +                for (Map.Entry<String, String> entry : prms) {
>> +                    s.append("    <param name='").append(entry.getKey()).append("'
>> value='").append(entry.getValue()).append("'/>\n");
>> +                }
>> +            }
>> +            s.append("  </applet-desc>\n")
>> +                    .append("</jnlp>\n");
>> +            OutputController.getLogger().log("toJnlp generated:");
>> +            OutputController.getLogger().log(s.toString());
>> +            return s.toString();
>> +        }
>> +
>> +    }
>> +
>>
>>
>> Is current version. Multilines kept, references fixed.
>
> Yep, looks much nicer now. ;-)
>

Indeed!