[rfc][icedtea-web] bringing applets out of browser (part2)

Jiri Vanek jvanek at redhat.com
Fri Dec 19 13:37:25 UTC 2014


>> +                   move[0] ++;
>> +                }
>>
>> Biggest nit here: Please refactor this into multiple functions (at least 1).
>
>
> Something like:
>
> if (optionParser.hasOption(OptionsDefinitions.OPTIONS.HTML)) {
>      bootAsHtml(...)
> } else {
>      [...]
> }
>
> private void bootAsHtml(...) {
>      [...]
> }
>
>>
>>
>> +            return null;

Please snip replies like this. I now hoep I have not overlooked something.

Anyway - your nit fixed - thank you for forcing me - I have moved those boot* impls to separate 
classes. Much better.

In adition this changeset contaisn also splash support during applets loading.

ty!

J.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: appletsOutOfBrowserShortcuts-head-08.patch
Type: text/x-patch
Size: 100731 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20141219/974acf1e/appletsOutOfBrowserShortcuts-head-08-0001.patch>


More information about the distro-pkg-dev mailing list